Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Fixed java-web-spring quotas to be able to run on OSIO #62

Conversation

ScrewTSW
Copy link
Member

What does this PR do?

This PR fixes the Java Springboot devfile memory quotas in order to be able to run the image on OSIO

What issues does this PR fix or reference?

Issue: https://github.com/redhat-developer/che-functional-tests/issues/556

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to generate an OOMKilled for the java language server; it seems like the java limit could safely be increased by ~200Mi and stay within quota, though, so that may fix it.

@ScrewTSW ScrewTSW changed the title Fixed java-web-spring quotas to be able to run on OSIO WIP: Fixed java-web-spring quotas to be able to run on OSIO Jul 26, 2019
@ScrewTSW
Copy link
Member Author

ScrewTSW commented Jul 29, 2019

so upon investigation there are three constants consuming quota limits:

  • JWT Proxy consumes 150MiB
  • Machine exec pod consumes 150MiB
  • Theia consumes 512MB = 488.281MiB

and the plugins defined in the devfile:

  • Java LSP : (value unset) -> changed to 1512MiB - Should definitely be enough to avoid LSP OOM restart
  • tools (maven) : 1024MiB (pointlessly large,-256MiB new value 768MiB)

That leaves me 1259.71875MiB to work with. After redistribution this leaves me exactly 3899392 bytes to spare or 3.71875MiB .

Java LSP peaked at 1258MiB
tools (maven) peaked at 385MiB even after rigorous usage

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
@ScrewTSW ScrewTSW force-pushed the 556-feature-fix-devfile-quotas-java-web-spring branch from 3ff22cb to 2eb64a8 Compare July 29, 2019 10:34
@ScrewTSW ScrewTSW changed the title WIP: Fixed java-web-spring quotas to be able to run on OSIO Fixed java-web-spring quotas to be able to run on OSIO Jul 29, 2019
@@ -12,6 +12,7 @@ components:
-
type: chePlugin
id: redhat/java/latest
memoryLimit: 1512Mi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially be dropped, as the default used for redhat/java/latest is 1500Mi. However this would mean any increases to the plugin-registry default would break this devfile again.

@ibuziuk ibuziuk merged commit 7868771 into eclipse-che:master Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants