From 38ba74e2beeb31c9035f14f3fc7663fba40ea62e Mon Sep 17 00:00:00 2001 From: Igor Vinokur Date: Thu, 30 Nov 2023 13:24:19 +0200 Subject: [PATCH] improve the GitHub Server subdomain isolation config description (#2667) * improve the GitHub Server subdomain isolation config description * Update modules/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc Co-authored-by: Jana Vrbkova --------- Co-authored-by: Jana Vrbkova --- .../partials/proc_applying-the-github-oauth-app-secret.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc b/modules/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc index 1ab3aa5388..28107f10a6 100644 --- a/modules/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc +++ b/modules/administration-guide/partials/proc_applying-the-github-oauth-app-secret.adoc @@ -36,7 +36,7 @@ metadata: annotations: che.eclipse.org/oauth-scm-server: github che.eclipse.org/scm-server-endpoint: ____ <2> - che.eclipse.org/scm-github-disable-subdomain-isolation: "____" <3> + che.eclipse.org/scm-github-disable-subdomain-isolation: true <3> type: Opaque stringData: id: ____ <4> @@ -44,7 +44,7 @@ stringData: ---- <1> The {prod-short} namespace. The default is `{prod-namespace}`. <2> This depends on the GitHub product your organization is using: When hosting repositories on GitHub.com or GitHub Enterprise Cloud, omit this line or enter the default `https://github.com`. When hosting repositories on GitHub Enterprise Server, enter the GitHub Enterprise Server URL. -<3> This line is only added for GitHub Enterprise Server. To disable subdomain isolation, set this to `"true"`. To enable subdomain isolation, set this to `"false"`. +<3> This line is only added for GitHub Enterprise Server with disabled link:https://docs.github.com/en/enterprise-server/admin/configuration/hardening-security-for-your-enterprise/enabling-subdomain-isolation#about-subdomain-isolation[subdomain isolation] option. If the subdomain isolation option is enabled on GitHub Enterprise Server, you must either omit this annotation or set it to `false`. <4> The *GitHub OAuth Client ID*. <5> The *GitHub OAuth Client Secret*.