Instructions for OpenShift OAuth provider #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
vinokurig
requested review from
yhontyk,
rkratky,
slemeur and
themr0c
as code owners
themr0c
reviewed
Feb 17, 2020
There was a problem hiding this comment.
Hi @vinokurig, thank you for the contribution. I left some suggestions for the formatting of links.
src/main/pages/che-7/end-user-guide/assembly_configuring-openshift-oauth.adoc
Outdated
Show resolved
Hide resolved
src/main/pages/che-7/end-user-guide/assembly_configuring-openshift-oauth.adoc
Outdated
Show resolved
Hide resolved
...main/pages/che-7/end-user-guide/proc_managing-pull-requests-using-the-github-pr-plug-in.adoc
Outdated
Show resolved
Hide resolved
…s-using-the-github-pr-plug-in.adoc
themr0c
approved these changes
Feb 17, 2020
MichalMaler
pushed a commit
to MichalMaler/che-docs
that referenced
this pull request
Feb 20, 2020
* Instructions for OpenShift OAuth provider Signed-off-by: Igor Vinokur <ivinokur@redhat.com> * fixup! Instructions for OpenShift OAuth provider * fixup! Instructions for OpenShift OAuth provider * Update src/main/pages/che-7/end-user-guide/assembly_configuring-openshift-oauth.adoc * Update src/main/pages/che-7/end-user-guide/proc_managing-pull-requests-using-the-github-pr-plug-in.adoc * Update src/main/pages/che-7/end-user-guide/assembly_configuring-openshift-oauth.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#116 # What does this PR do?
What issues does this PR fix or reference?
depends on eclipse-che/che#15963, eclipse-che/che#16006, eclipse-che/che#15672. Please don't merge this PR until the related PRs are merged.