Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Minimal set of permissions to deploy che on openshift #2794

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 7, 2024

What does this pull request change?

chore: Minimal set of permissions to deploy che on openshift

What issues does this pull request fix or reference?

eclipse-che/che#23056

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha requested review from deerskindoll and a team as code owners October 7, 2024 11:16
@tolusha tolusha requested a review from svor October 7, 2024 11:16
Copy link

github-actions bot commented Oct 7, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Oct 7, 2024

🎊 Navigate the preview: 🎊

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of small suggestions

tolusha and others added 3 commits October 7, 2024 15:00
…on-openshift-using-the-web-console.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…on-openshift-using-cli.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tolusha tolusha merged commit d810024 into main Oct 8, 2024
10 checks passed
@tolusha tolusha deleted the 23056 branch October 8, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants