Fix devworkspaces gateway rules creation on kubernetes #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun,
nickboldt and
tolusha
as code owners
mshaposhnik
requested review from
sparkoo and
metlos
and removed request for
nickboldt,
mmorhun and
flacatus
tolusha
approved these changes
Sep 9, 2021
|
@mshaposhnik: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
sparkoo
approved these changes
Sep 9, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mshaposhnik, sparkoo, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix kubernetes gateway rules creation to avoid traefik misconfiguration by unexisting (on K8S) plugin.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20375
How to test this PR?
Run devworkspace on minikube. Workspaces is started but there is error opening workspace by its URL and errors in the logs of the gateway pod.
Use test image
mshaposh/che-operator:nightlyfixes the situation.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.