Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto enable dev workspace engine after olm channel migration #1160

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this PR do?

feat: Auto enable dev workspace engine after olm channel migration

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Some part of the eclipse-che/che#20629

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

/retest

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #1160 (4edf902) into main (4de5df7) will decrease coverage by 0.08%.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
- Coverage   57.39%   57.31%   -0.09%     
==========================================
  Files          74       75       +1     
  Lines        8645     8658      +13     
==========================================
  Hits         4962     4962              
- Misses       3143     3155      +12     
- Partials      540      541       +1     
Impacted Files Coverage Δ
controllers/che/checluster_controller.go 24.46% <0.00%> (-0.24%) ⬇️
pkg/deploy/defaults.go 51.45% <ø> (ø)
pkg/util/namespace_provider.go 0.00% <0.00%> (ø)
pkg/deploy/dev-workspace/dev_workspace.go 69.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de5df7...4edf902. Read the comment docs.

@tolusha tolusha mentioned this pull request Nov 1, 2021
25 tasks
@tolusha
Copy link
Contributor

tolusha commented Nov 2, 2021

As far as I understand, DevWorkspace is not enabled after switching from one channel to another.
But the code above says nothing about channels but namespaces, so I would put this into migration doc.

@tolusha
Copy link
Contributor

tolusha commented Nov 2, 2021

Must be a part of eclipse-che/che#20614

@tolusha tolusha closed this Nov 2, 2021
@tolusha tolusha deleted the autoEnableDevWorkspaceEngineAfterOLMChannelMigration branch January 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants