chore: Refactoring OpenShiftOAuth

[tolusha]

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Refactoring OpenShiftOAuth

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19284

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Custom resource definition file is up to date
• OLM bundles are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[codecov]

Codecov Report

Merging #1167 (10ec4ae) into main (3e2be04) will increase coverage by 0.03%.
The diff coverage is 58.10%.

@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
+ Coverage   57.41%   57.45%   +0.03%     
==========================================
  Files          75       76       +1     
  Lines        8639     8642       +3     
==========================================
+ Hits         4960     4965       +5     
+ Misses       3140     3139       -1     
+ Partials      539      538       -1     

Impacted Files	Coverage Δ
pkg/deploy/dashboard/dashboard.go	59.25% <0.00%> (ø)
pkg/deploy/identity-provider/identity_provider.go	10.23% <0.00%> (ø)
pkg/deploy/server/server_deployment.go	67.89% <0.00%> (ø)
pkg/util/util.go	14.63% <ø> (+0.08%)	⬆️
pkg/deploy/openshift-oauth/openshiftoauth.go	47.91% <47.91%> (ø)
controllers/che/create.go	44.80% <66.66%> (+0.50%)	⬆️
controllers/che/checluster_controller.go	24.34% <100.00%> (-2.40%)	⬇️
controllers/che/gateway_permission.go	62.16% <100.00%> (ø)
pkg/deploy/gateway/gateway.go	85.86% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2be04...10ec4ae. Read the comment docs.

[mmorhun]

Why do we have a dependency between these reconcilers?

[tolusha]

It is dependency between class.
Because they actually depends on each other.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment