Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: printing url when Eclipse Che is available #1224

Merged
merged 2 commits into from
Dec 6, 2021
Merged

fix: printing url when Eclipse Che is available #1224

merged 2 commits into from
Dec 6, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 6, 2021

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Update Eclipse Che custom resource to set a valid ingress domain for a Kubernetes cluster:

```bash
yq -riY '.spec.k8s.ingressDomain = "<DOMAIN>"' org.eclipse.che_v1_checluster.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe here is we have to use kubectl. I'm not sure that users notified earlier to install yq, and I don't think that's a good requirement.

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-che-behind-proxy 6fbac8c link true /test v8-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Dec 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

New changes are detected. LGTM label has been removed.

@tolusha tolusha merged commit 812d343 into main Dec 6, 2021
@tolusha tolusha deleted the fixes branch December 6, 2021 09:04
@che-bot che-bot added this to the 7.41 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants