feat: set CHE_NAMESPACE and CHE_CRD_OBJECT_NAME env vars

[dkwon17]

Signed-off-by: David Kwon dakwon@redhat.com

What does this PR do?

Sets CHE_NAMESPACE and CHE_CRD_OBJECT_NAME vars for the che-dashboard deployment.
This is done to use to use the ServerConfigApi from che-dashboard.

The second commit adds the server.workspacesDefaultPlugins field in the Che CR. For example:

  server:
    workspacesDefaultPlugins:
      - editor: 'eclipse/che-theia/latest'
        plugins: ['https://eclipse-che.github.io/che-plugin-registry/main/v3/plugins/containers/buildah/latest/devfile.yaml']

What issues does this PR fix or reference?

eclipse-che/che#20090

How to test this PR?

To deploy:
Can be tested by following these steps: https://github.com/eclipse-che/che-operator#deploy-che-operator-with-chectl-using---installer-olm-flag

I have tested this PR on CRC with this catalog image: quay.io/dkwon17/eclipse-che-openshift-opm-catalog:next.

Example:

chectl server:deploy --installer=olm --platform=openshift --catalog-source-yaml ./mycatalog.yaml --olm-channel=next --package-manifest-name=eclipse-che-preview-openshift

To test:
1. Checking the che-dashboard pod's environment variables:

2. Checking the CheCluster CR for the new field:

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Custom resource definition file is up to date
• OLM bundles are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[tolusha]

I don't think adding anything regarding workspces into a CheCluster CR is a good idea.

[dkwon17]

Could we reconsider? This was the workflow proposed in the issue: eclipse-che/che#20090 (comment)

[dkwon17]

Also, why are fields regarding workspaces in the Che CR not a good idea? I think I am missing some context.

[ibuziuk]

I don't think adding anything regarding workspces into a CheCluster CR is a good idea.

@tolusha could you please clarify why do you think that this is a bad idea?
We have discussed the design proposal with devex team cc: @l0rd

[dkwon17]

Thank you for the feedback @tolusha , I made some changes

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, ibuziuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tolusha]

/retest

[ibuziuk]

/retest

[openshift-ci]

@dkwon17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v9-devworkspace-happy-path	051d7bd	link	true	/test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tolusha]

pls merge