Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switching to DevWorkspace engine by default #1249

Closed
wants to merge 0 commits into from
Closed

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 13, 2021

What does this PR do?

Switching to DevWorkspace engine by default:

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20866

How to test this PR?

See PR checks

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Dec 13, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #1249 (f0c979b) into main (f0bb5ae) will increase coverage by 3.80%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   56.77%   60.57%   +3.80%     
==========================================
  Files          84       81       -3     
  Lines        8728     7465    -1263     
==========================================
- Hits         4955     4522     -433     
+ Misses       3275     2489     -786     
+ Partials      498      454      -44     
Impacted Files Coverage Δ
pkg/deploy/defaults.go 45.58% <ø> (-0.13%) ⬇️
pkg/deploy/dev-workspace/dev_workspace.go 55.55% <ø> (-1.83%) ⬇️
.../identity-provider/identity_provider_reconciler.go 0.00% <0.00%> (-8.60%) ⬇️
...deploy/identity-provider/identity_provider_util.go 0.00% <ø> (ø)
pkg/deploy/ingress.go 72.72% <ø> (+4.35%) ⬆️
pkg/deploy/postgres/postgres.go 36.84% <ø> (+13.43%) ⬆️
pkg/deploy/server/default_values_reconciler.go 45.54% <ø> (+0.60%) ⬆️
pkg/deploy/server/server_deployment.go 72.98% <ø> (+5.20%) ⬆️
pkg/deploy/tls/tls_secret.go 0.00% <ø> (ø)
pkg/util/util.go 18.53% <ø> (+3.89%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0bb5ae...f0c979b. Read the comment docs.

@tolusha
Copy link
Contributor Author

tolusha commented Dec 17, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2021

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-e2e-all-namespaces-deployment 78a79cd link true /test v8-e2e-all-namespaces-deployment
ci/prow/v8-multi-host-next-deployment 78a79cd link true /test v8-multi-host-next-deployment
ci/prow/v8-single-host-next-deployment 78a79cd link true /test v8-single-host-next-deployment
ci/prow/v9-stable-to-nightly 78a79cd link true /test v9-stable-to-nightly
ci/prow/v9-multi-host-next-deployment 78a79cd link true /test v9-multi-host-next-deployment
ci/prow/v9-single-host-nightly-deployment 78a79cd link true /test v9-single-host-nightly-deployment
ci/prow/v9-operator-test 7f8b40d link true /test v9-operator-test
ci/prow/v8-operator-test 7f8b40d link true /test v8-operator-test
ci/prow/v9-devworkspace-happy-path 7f8b40d link true /test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha deleted the 20866 branch August 31, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant