Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Propagate proxy config into oauth-proxy sidecar container #1317

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Feb 3, 2022

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Propagate proxy config into oauth-proxy sidecar container

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#21088

How to test this PR?

  1. launch openshift cluster behind proxy
  2. deploy Eclipse Che
chectl server:deploy \
     --platform openshift \
     --che-operator-image abazko/operator:21088

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1317 (1bb9459) into main (df718e6) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
+ Coverage   60.46%   60.53%   +0.06%     
==========================================
  Files          77       77              
  Lines        6342     6353      +11     
==========================================
+ Hits         3835     3846      +11     
  Misses       2121     2121              
  Partials      386      386              
Impacted Files Coverage Δ
pkg/deploy/gateway/gateway.go 84.41% <100.00%> (ø)
pkg/deploy/gateway/oauth_proxy.go 76.15% <100.00%> (+2.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df718e6...1bb9459. Read the comment docs.

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amisevsk
Copy link
Contributor

amisevsk commented Feb 3, 2022

@tolusha Is there an image built with both this PR and #1318? I'd like to verify both at once in a proxy environment

@tolusha
Copy link
Contributor Author

tolusha commented Feb 3, 2022

Pls use docker.io/abazko/operator:proxy includes (both PRs)

@amisevsk
Copy link
Contributor

amisevsk commented Feb 3, 2022

Tested on OpenShift 4.9 with proxy enabled. Issue eclipse-che/che#21088 is fixed and dashboard is accessible 👍

@tolusha tolusha merged commit 4516e3b into main Feb 3, 2022
@tolusha tolusha deleted the 21088 branch February 3, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants