Updated oc-test-happy-path.sh according to new test scripts in "Che" project #1641

nallikaea · 2023-03-20T11:31:08Z

What does this PR do?

According to task #22043 test scripts were updated, necessary changes added to this repository.
PR: #22052

The old npm script "test-empty-workspace-devworkspace-happy-path-code" runs one test spec file - "EmptyWorkspace.spec.ts" from the test directory and uses hard-coded mocha config.
It was replaced with "test-all-devfiles" which uses new dynamic mocha config and will run the same file if variable "USERSTORY=EmptyWorkspace" or all test specs in the test directory if variable not set.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

How to test this PR?

Run happy-pass PR check.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…oject #22043 Signed-off-by: mdolhalo <mdolhalo@redhat.com>

openshift-ci · 2023-03-20T11:31:22Z

Hi @nallikaea. Thanks for your PR.

I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-20T11:31:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nallikaea

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tolusha · 2023-03-20T11:42:04Z

@nallikaea
Could you describe what test-all-devfiles is about?

codecov · 2023-03-20T11:43:20Z

Codecov Report

Merging #1641 (0ba44f6) into main (239b536) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
- Coverage   57.95%   57.92%   -0.03%     
==========================================
  Files          70       70              
  Lines        8220     8224       +4     
==========================================
  Hits         4764     4764              
- Misses       3136     3140       +4     
  Partials      320      320

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nallikaea · 2023-03-20T12:01:21Z

@tolusha sure, description updated

tolusha · 2023-03-20T13:28:50Z

@nallikaea

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/eclipse-che_che-operator/1641/pull-ci-eclipse-che-che-operator-main-v12-devworkspace-happy-path/1637790262698708992

/tmp/e2e/node_modules/mocha/lib/cli/config.js:80
    throw createUnparsableFileError(
    ^
Error: Unable to read/parse mocha-all-devfiles-.json: Error: ENOENT: no such file or directory, open 'mocha-all-devfiles-.json'
    at createUnparsableFileError (/tmp/e2e/node_modules/mocha/lib/errors.js:514:13)
    at exports.loadConfig (/tmp/e2e/node_modules/mocha/lib/cli/config.js:80:11)
    at loadRc (/tmp/e2e/node_modules/mocha/lib/cli/options.js:162:21)
    at loadOptions (/tmp/e2e/node_modules/mocha/lib/cli/options.js:234:20)
    at Object.<anonymous> (/tmp/e2e/node_modules/mocha/bin/mocha:27:14)
    at Module._compile (node:internal/modules/cjs/loader:1191:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1245:10)
    at Module.load (node:internal/modules/cjs/loader:1069:32)
    at Function.Module._load (node:internal/modules/cjs/loader:904:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
  code: 'ERR_MOCHA_UNPARSABLE_FILE'

nallikaea · 2023-03-20T18:56:24Z

@nallikaea

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/eclipse-che_che-operator/1641/pull-ci-eclipse-che-che-operator-main-v12-devworkspace-happy-path/1637790262698708992

/tmp/e2e/node_modules/mocha/lib/cli/config.js:80
    throw createUnparsableFileError(
    ^
Error: Unable to read/parse mocha-all-devfiles-.json: Error: ENOENT: no such file or directory, open 'mocha-all-devfiles-.json'
    at createUnparsableFileError (/tmp/e2e/node_modules/mocha/lib/errors.js:514:13)
    at exports.loadConfig (/tmp/e2e/node_modules/mocha/lib/cli/config.js:80:11)
    at loadRc (/tmp/e2e/node_modules/mocha/lib/cli/options.js:162:21)
    at loadOptions (/tmp/e2e/node_modules/mocha/lib/cli/options.js:234:20)
    at Object.<anonymous> (/tmp/e2e/node_modules/mocha/bin/mocha:27:14)
    at Module._compile (node:internal/modules/cjs/loader:1191:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1245:10)
    at Module.load (node:internal/modules/cjs/loader:1069:32)
    at Function.Module._load (node:internal/modules/cjs/loader:904:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
  code: 'ERR_MOCHA_UNPARSABLE_FILE'

thank you, @tolusha. this is expected result, because PR eclipse-che/che#22052 has not merged yet

tolusha · 2023-03-21T06:51:57Z

/retest

tolusha · 2023-03-21T08:09:12Z

/retest

tolusha · 2023-03-21T09:07:52Z

/retest

nallikaea · 2023-03-21T14:16:41Z

/retest

tolusha · 2023-03-21T15:43:32Z

/retest

tolusha · 2023-03-22T06:37:56Z

/retest

tolusha · 2023-03-22T07:37:10Z

@nallikaea
Could you check please
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/eclipse-che_che-operator/1641/pull-ci-eclipse-che-che-operator-main-v12-devworkspace-happy-path/1638429800630587392/artifacts/devworkspace-happy-path/devworkspace-happy-path/

dmytro-ndp · 2023-03-22T09:23:43Z

@nallikaea : it seems there is a mistake in https://github.com/eclipse/che/blame/main/tests/e2e/configs/sh-scripts/initDevfileTests.sh#L23 - redundant exit 1.

Also, it's not clear why $TS_SELENIUM_EDITOR is empty when execute "initDevfileTests.sh".

@ScrewTSW, @musienko-maxim: cc

nallikaea · 2023-03-22T10:40:29Z

eclipse-che/che#22084

fix merged

nallikaea · 2023-03-22T10:56:25Z

/retest

nallikaea · 2023-03-22T12:10:58Z

/retest

nallikaea · 2023-03-22T13:33:07Z

@tolusha @dmytro-ndp @musienko-maxim
ci/prow/v12-devworkspace-happy-path — Job succeeded.

Updated oc-test-happy-path.sh according to new test scripts in che pr…

0ba44f6

…oject #22043 Signed-off-by: mdolhalo <mdolhalo@redhat.com>

nallikaea requested review from nickboldt, tolusha, AndrienkoAleksandr and flacatus as code owners March 20, 2023 11:31

openshift-ci bot added the needs-ok-to-test label Mar 20, 2023

nallikaea mentioned this pull request Mar 20, 2023

Clean up Che Theia specific tests and page objects eclipse-che/che#22052

Merged

9 tasks

tolusha added the ok-to-test label Mar 20, 2023

openshift-ci bot removed the needs-ok-to-test label Mar 21, 2023

This was referenced Mar 22, 2023

Add the Smoke test PR check for Che-Server repository eclipse-che/che#22047

Closed

Add the Smoke test PR check for Operator repository eclipse-che/che#22046

Closed

nallikaea mentioned this pull request Mar 22, 2023

Updated launch.sh and startHappyPathTest() eclipse-che/che#22087

Merged

9 tasks

tolusha merged commit b511a9a into eclipse-che:main Mar 22, 2023

dmytro-ndp mentioned this pull request Mar 22, 2023

Clean up Che Theia specific tests and page objects from Eclipse Che typescript functional tests eclipse-che/che#22043

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated oc-test-happy-path.sh according to new test scripts in "Che" project #1641

Updated oc-test-happy-path.sh according to new test scripts in "Che" project #1641

nallikaea commented Mar 20, 2023 •

edited

Loading

openshift-ci bot commented Mar 20, 2023

openshift-ci bot commented Mar 20, 2023

tolusha commented Mar 20, 2023

codecov bot commented Mar 20, 2023

nallikaea commented Mar 20, 2023

tolusha commented Mar 20, 2023

nallikaea commented Mar 20, 2023

tolusha commented Mar 21, 2023

tolusha commented Mar 21, 2023

tolusha commented Mar 21, 2023

nallikaea commented Mar 21, 2023

tolusha commented Mar 21, 2023

tolusha commented Mar 22, 2023

tolusha commented Mar 22, 2023

dmytro-ndp commented Mar 22, 2023 •

edited

Loading

nallikaea commented Mar 22, 2023

nallikaea commented Mar 22, 2023

nallikaea commented Mar 22, 2023

nallikaea commented Mar 22, 2023

Updated oc-test-happy-path.sh according to new test scripts in "Che" project #1641

Updated oc-test-happy-path.sh according to new test scripts in "Che" project #1641

Conversation

nallikaea commented Mar 20, 2023 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

openshift-ci bot commented Mar 20, 2023

openshift-ci bot commented Mar 20, 2023

tolusha commented Mar 20, 2023

codecov bot commented Mar 20, 2023

Codecov Report

nallikaea commented Mar 20, 2023

tolusha commented Mar 20, 2023

nallikaea commented Mar 20, 2023

tolusha commented Mar 21, 2023

tolusha commented Mar 21, 2023

tolusha commented Mar 21, 2023

nallikaea commented Mar 21, 2023

tolusha commented Mar 21, 2023

tolusha commented Mar 22, 2023

tolusha commented Mar 22, 2023

dmytro-ndp commented Mar 22, 2023 • edited Loading

nallikaea commented Mar 22, 2023

nallikaea commented Mar 22, 2023

nallikaea commented Mar 22, 2023

nallikaea commented Mar 22, 2023

nallikaea commented Mar 20, 2023 •

edited

Loading

dmytro-ndp commented Mar 22, 2023 •

edited

Loading