Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DevWorkspace Operator dependency to v0.25.0 #1805

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

amisevsk
Copy link
Contributor

What does this PR do?

Updates the DevWorkspace Operator dependency to v0.25.0. This also pulls in devfile/api v2.2.2.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

General maintenance
Fixes eclipse-che/che#22068

How to test this PR?

Functionally should be no changes except eclipse-che/che#22068 is resolved

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44c3582) 59.73% compared to head (629ea8c) 59.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files          74       74           
  Lines        9102     9102           
=======================================
  Hits         5437     5437           
  Misses       3290     3290           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Copy link

openshift-ci bot commented Jan 31, 2024

@amisevsk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy dc28a2a link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibuziuk
Copy link
Member

ibuziuk commented Jan 31, 2024

@amisevsk could you please clarify the process of how DWO version is updated
cc: @AObuchow just want to make sure that we have it documented

@amisevsk
Copy link
Contributor Author

To update the DWO dependency, all we need to do is update the version in go.mod and run go mod tidy + go mod vendor.

After vendoring, it's necessary to look for any changed dependencies (transitive dependencies of DWO) and update DEPENDENCIES.md with the new versions + links to clearlydefined/similar to validate licensing.

You can see the entirety of the manual changes in the first commit in this PR: bd0e50f. The second commit is just the result of running go mod vendor.

@tolusha is more familiar with this process for the Che Operator than I am.

Copy link

openshift-ci bot commented Jan 31, 2024

@AObuchow: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amisevsk
Copy link
Contributor Author

Leaving this open for Anatolii to review and merge, since I'm not 100% I got every step of the process

Copy link

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, AObuchow, ibuziuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit f1740f8 into eclipse-che:main Feb 1, 2024
18 of 19 checks passed
@devstudio-release
Copy link

Build 3.12 :: operator_3.x/346: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: operator_3.x/346: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6132 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6030: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 58586154 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: get-sources-rhpkg-container-build_3.x/6031: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 58588744 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@amisevsk amisevsk deleted the update-dwo-0.25 branch February 1, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error is not meanful when workspace startup fails because route quota is exceeded
5 participants