-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable internal cluster SVC names usage by default #919
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 49.66% 49.79% +0.13%
==========================================
Files 56 56
Lines 6669 6669
==========================================
+ Hits 3312 3321 +9
+ Misses 3009 2996 -13
- Partials 348 352 +4
Continue to review full report at Codecov.
|
New changes are detected. LGTM label has been removed. |
/retest |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
useInternalClusterSVCNames
fielddisableInternalClusterSVCNames
without default value which enables internal cluster SVC names usage by default on the clusterScreenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#19726
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.