Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable internal cluster SVC names usage by default #919

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jul 13, 2021

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

  1. Deprecate useInternalClusterSVCNames field
  2. Introduce disableInternalClusterSVCNames without default value which enables internal cluster SVC names usage by default on the cluster

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19726

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

tolusha added 2 commits July 15, 2021 10:37
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #919 (4b7aeeb) into main (e29484f) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   49.66%   49.79%   +0.13%     
==========================================
  Files          56       56              
  Lines        6669     6669              
==========================================
+ Hits         3312     3321       +9     
+ Misses       3009     2996      -13     
- Partials      348      352       +4     
Impacted Files Coverage Δ
pkg/controller/che/proxy.go 61.11% <100.00%> (ø)
...kg/deploy/identity-provider/deployment_keycloak.go 55.20% <100.00%> (+1.71%) ⬆️
pkg/deploy/server/server_configmap.go 85.50% <100.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29484f...4b7aeeb. Read the comment docs.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Jul 15, 2021
@tolusha
Copy link
Contributor Author

tolusha commented Jul 15, 2021

/retest

@tolusha tolusha merged commit ac0bd56 into main Jul 15, 2021
@tolusha tolusha deleted the 20085 branch July 15, 2021 14:21
@che-bot che-bot added this to the 7.34 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants