Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Start workspace with devfilev2 when devworkspace is enabled in our e2e tests #920

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

flacatus
Copy link
Contributor

@flacatus flacatus commented Jul 13, 2021

Signed-off-by: Flavius Lacatusu flacatus@redhat.com

What does this PR do?

Start devfile v1 when devworkspace is not enabled and start workspace v2 when devworkspace engine it is enabled

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20072

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, flacatus, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jul 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2021

New changes are detected. LGTM label has been removed.

@flacatus
Copy link
Contributor Author

/retest

@flacatus
Copy link
Contributor Author

/test v8-multi-host-nightly-deployment

@tolusha
Copy link
Contributor

tolusha commented Jul 13, 2021

/retest

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Contributor Author

/retest

4 similar comments
@flacatus
Copy link
Contributor Author

/retest

@tolusha
Copy link
Contributor

tolusha commented Jul 13, 2021

/retest

@flacatus
Copy link
Contributor Author

/retest

@tolusha
Copy link
Contributor

tolusha commented Jul 14, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2021

@flacatus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v8-che-behind-proxy 8e38b77 link /test v8-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flacatus flacatus merged commit da1bc3b into main Jul 14, 2021
@flacatus flacatus deleted the dwo_engine_tests branch July 14, 2021 06:58
@che-bot che-bot added this to the 7.34 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants