-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Start workspace with devfilev2 when devworkspace is enabled in our e2e tests #920
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, flacatus, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
57b0a90
to
feba94f
Compare
New changes are detected. LGTM label has been removed. |
/retest |
/test v8-multi-host-nightly-deployment |
/retest |
feba94f
to
4f8e85c
Compare
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
4f8e85c
to
8e38b77
Compare
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
@flacatus: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Flavius Lacatusu flacatus@redhat.com
What does this PR do?
Start devfile v1 when devworkspace is not enabled and start workspace v2 when devworkspace engine it is enabled
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20072
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.