Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting keycloak system properties for rh-sso #928

Merged
merged 1 commit into from
Jul 14, 2021
Merged

fix: setting keycloak system properties for rh-sso #928

merged 1 commit into from
Jul 14, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jul 14, 2021

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Jul 14, 2021
@AndrienkoAleksandr
Copy link
Contributor

Tested pr using dog fooding cluster and selenium test. After 7 execution in 5 threads and 33 executions in 8 threads keycloak log is clear and I didn't saw error page.

@tolusha
Copy link
Contributor Author

tolusha commented Jul 14, 2021

/retest

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #928 (03b28f7) into main (9bb621b) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
- Coverage   49.75%   49.66%   -0.09%     
==========================================
  Files          56       56              
  Lines        6657     6669      +12     
==========================================
  Hits         3312     3312              
- Misses       2998     3009      +11     
- Partials      347      348       +1     
Impacted Files Coverage Δ
...kg/deploy/identity-provider/deployment_keycloak.go 53.49% <0.00%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb621b...03b28f7. Read the comment docs.

@tolusha tolusha merged commit e29484f into main Jul 14, 2021
@tolusha tolusha deleted the 1426 branch July 14, 2021 18:00
@che-bot che-bot added this to the 7.34 milestone Jul 14, 2021
nickboldt pushed a commit that referenced this pull request Jul 15, 2021
Change-Id: I952ab093f4f7b7c1a088e3cfbd8b9052c6f03111
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants