Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use vendor folder to speed up image build. #947

Merged
merged 6 commits into from
Jul 20, 2021

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Jul 19, 2021

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr changed the title Use vendor folder to speed up image build. fix Use vendor folder to speed up image build. Jul 19, 2021
@flacatus
Copy link
Contributor

/retest

@AndrienkoAleksandr AndrienkoAleksandr changed the title fix Use vendor folder to speed up image build. fix: Use vendor folder to speed up image build. Jul 20, 2021
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jul 20, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, flacatus, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jul 20, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2021

New changes are detected. LGTM label has been removed.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@tolusha
Copy link
Contributor

tolusha commented Jul 20, 2021

/retest

1 similar comment
@tolusha
Copy link
Contributor

tolusha commented Jul 20, 2021

/retest

@tolusha
Copy link
Contributor

tolusha commented Jul 20, 2021

Check failed on server:logs command.
Basically it is good to merge but I've rerun one more time

@tolusha
Copy link
Contributor

tolusha commented Jul 20, 2021

/retest

@tolusha tolusha mentioned this pull request Jul 20, 2021
11 tasks
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #947 (5062334) into main (f555494) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #947   +/-   ##
=======================================
  Coverage   49.93%   49.93%           
=======================================
  Files          56       56           
  Lines        6628     6628           
=======================================
  Hits         3310     3310           
  Misses       2964     2964           
  Partials      354      354           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f555494...5062334. Read the comment docs.

@AndrienkoAleksandr AndrienkoAleksandr merged commit 3141f09 into main Jul 20, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the speedUpImageBuild branch July 20, 2021 16:19
@che-bot che-bot added this to the 7.34 milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants