-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Che 7.1.0 version of the plugin-registry #216
Conversation
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
…plugins Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
…ugins to '7.1.0' Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
…m 'next' to '7.1.0' Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
hello, AFAIK branch had by conventions |
@benoitf hi, we did the same for |
@ibuziuk https://github.com/eclipse/che-plugin-registry/tree/7.0.x (it's called |
icon: https://raw.githubusercontent.com/theia-ide/theia/master/logo/theia-logo-no-text-black.svg?sanitize=true | ||
category: Editor | ||
repository: https://github.com/eclipse/che-theia | ||
firstPublicationDate: "2019-03-07" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that it's today the first publication date for che-theia 7.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, but I believe we have not updated the firstPublicationDate
before and it might be assumed that firstPublicationDate
= firstPublicationDate of plugin in general, but I'm not sure
ok, I can rename the branch but it will not be consistent with https://github.com/eclipse/che-devfile-registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine for me
@benoitf changed the branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving again 👍
What does this PR do?
Release Che 7.1.0 version of the plugin-registry eclipse-che/che#14352:
find . -name '*.yaml' -exec sed -i -e 's/:next/:7.1.0/g' {} \;
Please review in commit-by-commit manner