-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add VS Camel K extension eclipse/che#14806 #247
Conversation
- requires a specific dockerfile with Kubectl and Kamel on cli. - Add Kubernetes extension which is a required dependency of VS Code Camel K tooling Signed-off-by: Aurélien Pupier <apupier@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe another person should review too
required docker image is now available https://hub.docker.com/r/eclipse/che-remote-plugin-camelk-0.0.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1, we're supposed to be migrating to Quay, not using dockerhub. Can you publish your required sidecar image there instead? and how is the image defined? Where's it's Dockerfile? Should it be in https://github.com/eclipse/che-theia/tree/master/dockerfiles with the rest of the sidecars?
firstPublicationDate: '2019-07-10' | ||
spec: | ||
containers: | ||
- image: "eclipse/che-remote-plugin-camelk-0.0.9:next" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use quay.io and in general we should always include the registry here, not just the org/image:tag
.
firstPublicationDate: '2019-07-10' | ||
spec: | ||
containers: | ||
- image: "eclipse/che-remote-plugin-camelk-0.0.9:next" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use quay.io and in general we should always include the registry here, not just the org/image:tag
.
@nickboldt che-theia builds are still publishing to docker hub (there is an other issue to move to quay.io) |
I prefer to stay on current system. As Florent mentioned, i think it will be handled by another specific task eclipse-che/che#14849
the Dockerfile is available herewith the rest of the sidecars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I'll submit a second PR to fix your eclipse/
-> docker.io/eclipse/
as I see the same problem for a few other plugins. Need that prefix to make it easier to convert to airgap mode.
@nickboldt the build.sh script should enforce that so the PR is failing if there is no organization |
Followup for approval #251 |
Camel K tooling
Signed-off-by: Aurélien Pupier apupier@redhat.com
What does this PR do?
Add VS Code Tooling for Apache Camel in Che Plugin registry
/!\ it requires this other PR to be merged with Dockerfile published: eclipse-che/che-theia#476Dockerfile published