Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang extension to 0.16.1 #581

Closed
wants to merge 6 commits into from
Closed

bump golang extension to 0.16.1 #581

wants to merge 6 commits into from

Conversation

gattytto
Copy link
Contributor

Signed-off-by: Esteban Mañaricua emanaricua@gmail.com

Closes eclipse-che/che#17665

Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2020

Can one of the admins verify this patch?

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2020

Can one of the admins verify this patch?

@ericwill
Copy link
Contributor

Any changes needed for the sidecar? Also, please update the go plugin entry in the vscode-extensions.json file. You can read more about it here.

Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
@gattytto
Copy link
Contributor Author

Any changes needed for the sidecar?

not that I could notice for now

please update the go plugin entry in the vscode-extensions.json file.

done.

Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
This reverts commit ec886ab.

Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
This reverts commit ec886ab.

Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
@ericwill
Copy link
Contributor

please update the go plugin entry in the vscode-extensions.json file.

done.

Seems your changes were reverted :/

@gattytto
Copy link
Contributor Author

please update the go plugin entry in the vscode-extensions.json file.

done.

Seems your changes were reverted :/

no I'm just trying to patch a commit I forgot to signoff but I think I'll just redo the PR. github is fun

@gattytto gattytto closed this Aug 25, 2020
@gattytto gattytto deleted the update_golang_extension_to_0.16.1 branch August 25, 2020 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade VS Code extension Go language support
3 participants