Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Used jakarta.persistence #125

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Sep 20, 2021

What does this PR do?

Used first release ofjakarta.persistence artifact under eclipse instead of javax.persistence. Can't use the latest 3.x based because guice-persistence doesn't support it.

Screenshot/screencast of this PR

n/a

What issues does this PR fix or reference?

eclipse-che/che#20247

How to test this PR?

  1. Build and deploy
  2. Start che-server
  3. Start workspace

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot
Copy link
Contributor

che-bot commented Sep 20, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@skabashnyuk skabashnyuk merged commit e7d725c into eclipse-che:main Sep 21, 2021
@skabashnyuk skabashnyuk deleted the persistence branch September 21, 2021 05:36
@che-bot che-bot added this to the 7.37 milestone Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants