Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix che-editor.yaml recognition #334

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: Fix che-editor.yaml recognition #334

merged 1 commit into from
Jul 25, 2022

Conversation

vinokurig
Copy link
Contributor

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Fix Gitlab API raw file request.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#21562

How to test this PR?

  1. Deploy Che with the che-server image from the PR: chectl server:deploy -p=openshift -i=quay.io/ivinokur/che-server:next1
  2. Configure Gitlab oAuth: https://www.eclipse.org/che/docs/stable/administration-guide/configuring-oauth-2-for-gitlab/#applying-the-gitlab-authorized-application-secret_che
  3. Create a factory from a Gitlab repo with custom che-editor.yaml e.g. https://gitlab.com/ivinokur/test.git

See: the che-editor.yaml is recognised

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
screenshot-eclipse-che apps ci-ln-hlz9d1t-72292 origin-ci-int-gce dev rhcloud com-2022 07 25-16_16_01

@vinokurig vinokurig merged commit 81836ff into main Jul 25, 2022
@vinokurig vinokurig deleted the che-21562 branch July 25, 2022 13:46
@che-bot che-bot added this to the 7.51 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the git repository is on gitlab.com .che/che-editor.yaml is ignored
5 participants