fix: If internal links are not specified, the external one should be used #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
amisevsk,
yhontyk,
ibuziuk,
metlos,
MichalMaler,
mshaposhnik,
nickboldt,
skabashnyuk,
sleshchenko and
tolusha
as code owners
metlos
reviewed
Jul 7, 2021
...he/workspace/infrastructure/kubernetes/provision/KubernetesCheApiInternalEnvVarProvider.java
Outdated
Show resolved
Hide resolved
24 tasks
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
31 tasks
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
changed the title
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
tolusha
approved these changes
Aug 2, 2021
skabashnyuk
approved these changes
Aug 2, 2021
xbaran4
pushed a commit
to xbaran4/che-server
that referenced
this pull request
Aug 4, 2021
…used (eclipse-che#45) * Don't set public url value to internal url settings. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If internal links are not specified, the external one should be used
What issues does this PR fix or reference?
eclipse-che/che#18643
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com