Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the way how Azure OAuth2 token is validated #460

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Mar 9, 2023

What does this PR do?

  • Request for a user profile with a current token to make sure that token is valid

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#22051

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the interesting thing is that validation works initially, but starts to fail after some time

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@ibuziuk ibuziuk merged commit d9ad2fb into main Mar 9, 2023
@ibuziuk ibuziuk deleted the 22051 branch March 9, 2023 17:09
@devstudio-release
Copy link

Build 3.6 :: server_3.x/135: Console, Changes, Git Data

@che-bot che-bot added this to the 7.63 milestone Mar 9, 2023
@devstudio-release
Copy link

@devstudio-release
Copy link

@tolusha
Copy link
Contributor Author

tolusha commented Mar 10, 2023

LGTM, the interesting thing is that validation works initially, but starts to fail after some time

The only reason why validation was working is that the token was valid itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants