Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: REST Service on the Che server-side that will initiate k8s namespace provisioning #61

Merged
merged 9 commits into from
Aug 3, 2021
Merged

feat: REST Service on the Che server-side that will initiate k8s namespace provisioning #61

merged 9 commits into from
Aug 3, 2021

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Jul 23, 2021 •
edited
Loading

What does this PR do?

REST Service on the Che server-side that will initiate k8s namespace provisioning

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes eclipse-che/che#20165

How to test this PR?

  1. Build che-server image or deploy quay.io/skabashn/che-server:che20165
  2. Run
 curl -X POST 'https://che-eclipse-che.appsXXXXXX.opentlc.com/api/kubernetes/namespace/provision' \
  -H 'Connection: keep-alive' \
  -H 'Pragma: no-cache' \
  -H 'Cache-Control: no-cache' \
  -H 'sec-ch-ua: "Chromium";v="92", " Not A;Brand";v="99", "Google Chrome";v="92"' \
  -H 'Accept: application/json, text/plain, */*' \
  -H 'Authorization: Bearer eyJhbGcXXXXXX' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Referer: https://che-eclipse-che.apps.cluster-2d72.2d72.sandbox321.opentlc.com/dashboard/' \
  -H 'Accept-Language: uk-UA,uk;q=0.9,ru-UA;q=0.8,ru;q=0.7,en-US;q=0.6,en;q=0.5' \
  -H 'Cookie: JSESSIONID=X; X=X; X=X' \
  --compressed
{"name":"user2-che","attributes":{"phase":"Active","description":"","displayName":""}}%
  1. New k8s namespace has to be provisioned.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@dmytro-ndp
Copy link
Contributor

[crw-ci-test --rebuild]

@che-bot
Copy link
Contributor

che-bot commented Jul 23, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@che-bot
Copy link
Contributor

che-bot commented Jul 29, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@skabashnyuk skabashnyuk marked this pull request as ready for review July 29, 2021 10:20
@che-bot
Copy link
Contributor

che-bot commented Jul 29, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

sleshchenko
sleshchenko reviewed Jul 29, 2021
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

metlos
metlos reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

...g/eclipse/che/workspace/infrastructure/kubernetes/api/server/KubernetesNamespaceService.java Outdated Show resolved Hide resolved
...g/eclipse/che/workspace/infrastructure/kubernetes/api/server/KubernetesNamespaceService.java Outdated Show resolved Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java Outdated Show resolved Hide resolved
...clipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactoryTest.java Outdated Show resolved Hide resolved
...clipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactoryTest.java Outdated Show resolved Hide resolved
@che-bot
Copy link
Contributor

che-bot commented Jul 29, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@skabashnyuk
Copy link
Contributor Author

tested on minikube and RHPDS (OpenShift 4.7)

Знімок екрана 2021-07-30 о 13 26 54

Знімок екрана 2021-07-30 о 13 28 34

@che-bot
Copy link
Contributor

che-bot commented Jul 30, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@skabashnyuk
fixup! fixup! Merge remote-tracking branch 'upstream/main' into che20165
cbfd318 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jul 30, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@skabashnyuk
fixup! fixup! fixup! Merge remote-tracking branch 'upstream/main' int…
f969ee7 
…o che20165

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 2, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@skabashnyuk skabashnyuk merged commit 74b47fa into eclipse-che:main Aug 3, 2021
@skabashnyuk skabashnyuk deleted the che20165 branch August 3, 2021 09:32
@che-bot che-bot added this to the 7.35 milestone Aug 3, 2021
@sleshchenko sleshchenko mentioned this pull request Aug 3, 2021
Closed
xbaran4 pushed a commit to xbaran4/che-server that referenced this pull request Aug 4, 2021
@skabashnyuk @xbaran4
feat: REST Service on the Che server-side that will initiate k8s name…
f8abc10 
…space provisioning (eclipse-che#61)

* feat: REST Service on the Che server-side that will initiate k8s namespace provisioning


Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko left review comments

@metlos metlos metlos left review comments

@mshaposhnik mshaposhnik mshaposhnik approved these changes

@sparkoo sparkoo sparkoo approved these changes

@amisevsk amisevsk Awaiting requested review from amisevsk

@nickboldt nickboldt Awaiting requested review from nickboldt

@xbaran4 xbaran4 Awaiting requested review from xbaran4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.35
Development

Successfully merging this pull request may close these issues.

REST Service on the Che server-side that will initiate k8s namespace provisioning
7 participants
@skabashnyuk @dmytro-ndp @che-bot @metlos @sparkoo @mshaposhnik @sleshchenko