Use getProviderUrl() instead of getHostName() when generating gitlab … #737
Conversation
| @@ -29,7 +29,7 @@ class GitlabAuthorizingFileContentProvider extends AuthorizingFileContentProvide | |||
| @Override | |||
| protected boolean isPublicRepository(GitlabUrl remoteFactoryUrl) { | |||
| try { | |||
| urlFetcher.fetch(remoteFactoryUrl.getHostName() + '/' + remoteFactoryUrl.getSubGroups()); | |||
| urlFetcher.fetch(remoteFactoryUrl.getProviderUrl() + '/' + remoteFactoryUrl.getSubGroups()); | |||
There was a problem hiding this comment.
@vinokurig so this method never actually worked since HostName is not URL, right?
There was a problem hiding this comment.
yes, this is a leftover from a refactoring.
|
@artaleks9 wondering if we can add PR check for that ? |
|
| @artaleks9 wondering if we can add PR check for that ? You mean a repository gitlab with |
|
@dmytro-ndp @artaleks9 we should consider backporting to 7.92.x and 7.94.x |
|
Verified on Che with The functionality works properly. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, ibuziuk, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.18 :: server_3.x/371: Console, Changes, Git Data |
|
Build 3.18 :: sync-to-downstream_3.x/8058: Console, Changes, Git Data |
|
Build 3.18 :: push-latest-container-to-quay_3.x/5022: Console, Changes, Git Data |
|
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8135: server : 3.x :: Build 65882636 : quay.io/devspaces/server-rhel8:3.18-10 |
|
Build 3.18 :: server_3.x/371: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8058 triggered |
|
Build 3.18 :: update-digests_3.x/7969: Console, Changes, Git Data |
|
Build 3.18 :: operator-bundle_3.x/3851: Console, Changes, Git Data |
|
Build 3.18 :: sync-to-downstream_3.x/8060: Console, Changes, Git Data |
|
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8137: devspaces-operator-bundle : 3.x :: Failed in 65882893 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Use getProviderUrl() instead of getHostName() when generating gitlab url parameter
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-7264
How to test this PR?
.devfile.yamlfile.See: workspace starts successfully.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.