This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
fix(ssh-plugin): Disable the plug-in on DevWorkspace as there is no REST API (including ssh) #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EST API (including ssh) Change-Id: I9fe4d0bf637c6fdba805fb1374dd67fbe807e083 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
ericwill,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1135 +/- ##
==========================================
+ Coverage 29.45% 32.40% +2.94%
==========================================
Files 277 285 +8
Lines 9336 9685 +349
Branches 1380 1462 +82
==========================================
+ Hits 2750 3138 +388
+ Misses 6487 6449 -38
+ Partials 99 98 -1
Continue to review full report at Codecov.
|
|
❌ E2E Happy path tests failed ❗
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
ericwill
approved these changes
Jun 11, 2021
|
[crw-ci-test] |
|
❌ E2E Happy path tests failed ❗
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
[crw-ci-test --rebuild] |
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is no ssh service yet with DevWorkspace. Disable it when running with devWorkspace instead of showing error messages about not finding SSH service
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19188
How to test this PR?
Start with DevWorkspace mode and check ssh-plugin is disabled (no warning notification about failure on ssh keys)
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next
Change-Id: I9fe4d0bf637c6fdba805fb1374dd67fbe807e083
Signed-off-by: Florent Benoit fbenoit@redhat.com