CHE-11443 Implement the containers plugin #13

olexii4 · 2019-01-09T08:57:55Z

Implement the containers plugin

AndrienkoAleksandr · 2019-01-09T10:58:10Z

plugins/containers-plugin/src/containers-tree.ts

+
+}
+
+export class TestDataProvider implements theia.TreeDataProvider<string> {


@olexii4 why it's called TestDataProvider?

Good catch. Just forgot to rename. I will fix it.

AndrienkoAleksandr · 2019-01-09T11:37:40Z

plugins/containers-plugin/src/containers-tree.ts

+
+export class TestDataProvider implements theia.TreeDataProvider<string> {
+
+    private onDidChangeTreeDataEmitter: theia.EventEmitter<any> = new theia.EventEmitter<any>();


EventEmitter has dispose method, I think it could be utilized: https://github.com/theia-ide/theia/blob/master/packages/plugin/src/theia.d.ts#L1722.

AndrienkoAleksandr · 2019-01-09T11:38:35Z

plugins/containers-plugin/src/containers-tree.ts

+export class TestDataProvider implements theia.TreeDataProvider<string> {
+
+    private onDidChangeTreeDataEmitter: theia.EventEmitter<any> = new theia.EventEmitter<any>();
+    readonly onDidChangeTreeData: theia.Event<any> = this.onDidChangeTreeDataEmitter.event;


Maybe void should be better instead of any

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2019-01-10T14:21:15Z

AndrienkoAleksandr · 2019-01-10T14:29:43Z

plugins/containers-plugin/src/containers-tree-data-provider.ts

+        return uniqueId;
+    }
+
+    dispose(): void {


You could return Disposible here and simplify code upper.

I don't think so

vitaliy-guliy · 2019-01-10T14:54:39Z

UI improvements:

rename terminal node to New terminal
add icon and Server: prefix to the server node

WDYT?

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2019-01-10T18:09:55Z

https://youtu.be/3a6ZGPdD5_Q

olexii4 · 2019-01-10T18:12:36Z

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2019-01-11T08:09:31Z

slemeur · 2019-01-11T08:26:37Z

@olexii4 : Thanks for adding the screenshots to the PR.

Quick feedbacks:

When a developer is in the context of building a Theia Plugin or doing Che in Che, I understand that you want to see the theia container. But in a general use case, when a developer is building an application (a NodeJS one for example), I don't think it's necessary to display the tooling containers by default. I would see an option to display/hide those tooling containers. (That can be added later, as there is another issue for that, related to tasks Apply ability filter user containers from among others che#11804)
Is there something happening when I'm doing a right click on one of the container? For example, execute a task in that container directly?

olexii4 · 2019-01-11T09:50:57Z

@slemeur

Great idea. I will add it after Apply ability filter user containers from among others che#11804.
Nothing happens when you are doing a right click on one of the treeView items. Implemented API for plugins doesn't support it.

slemeur · 2019-01-11T09:52:32Z

On 2. Is it an API gap or is it something that just does not exist?

olexii4 · 2019-01-11T10:39:13Z

@slemeur
If I am not mistaken, it is doesn't supported in plugin API at all

l0rd · 2019-01-11T12:48:23Z

This is really cool! One comment: we should replace servers with endpoints or services.

olexii4 requested review from vitaliy-guliy, akurinnoy and evidolob January 9, 2019 08:58

AndrienkoAleksandr reviewed Jan 9, 2019

View reviewed changes

olexii4 changed the title ~~CHE-11443 Implement the containers plugin~~ [WIP] CHE-11443 Implement the containers plugin Jan 9, 2019

AndrienkoAleksandr reviewed Jan 9, 2019

View reviewed changes

olexii4 force-pushed the CHE-11443 branch from 936ca54 to 4abc147 Compare January 9, 2019 12:21

CHE-11443 implement the containers plugin

bd899d6

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the CHE-11443 branch from 4abc147 to bd899d6 Compare January 10, 2019 14:09

olexii4 changed the title ~~[WIP] CHE-11443 Implement the containers plugin~~ CHE-11443 Implement the containers plugin Jan 10, 2019

AndrienkoAleksandr reviewed Jan 10, 2019

View reviewed changes

AndrienkoAleksandr approved these changes Jan 10, 2019

View reviewed changes

code cleanup

ce5b744

Signed-off-by: Oleksii Orel <oorel@redhat.com>

akurinnoy approved these changes Jan 11, 2019

View reviewed changes

improve containers tree

f13929b

Signed-off-by: Oleksii Orel <oorel@redhat.com>

vitaliy-guliy approved these changes Jan 11, 2019

View reviewed changes

evidolob approved these changes Jan 11, 2019

View reviewed changes

AndrienkoAleksandr mentioned this pull request Jan 11, 2019

Filter workspace containers like tools and user's eclipse-che/che#12386

Merged

olexii4 merged commit e185f77 into master Jan 11, 2019

olexii4 deleted the CHE-11443 branch January 11, 2019 12:34

olexii4 mentioned this pull request Jan 11, 2019

Rename servers to endpoints #18

Merged

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

Add script to check plugins during the CI build (#13)

3c728c8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CHE-11443 Implement the containers plugin #13

CHE-11443 Implement the containers plugin #13

olexii4 commented Jan 9, 2019 •

edited

Loading

AndrienkoAleksandr Jan 9, 2019

olexii4 Jan 9, 2019

AndrienkoAleksandr Jan 9, 2019

olexii4 Jan 10, 2019

AndrienkoAleksandr Jan 9, 2019

olexii4 Jan 10, 2019

olexii4 commented Jan 10, 2019

AndrienkoAleksandr Jan 10, 2019

olexii4 Jan 10, 2019 •

edited

Loading

vitaliy-guliy commented Jan 10, 2019

olexii4 commented Jan 10, 2019

olexii4 commented Jan 10, 2019

olexii4 commented Jan 11, 2019

slemeur commented Jan 11, 2019 •

edited

Loading

olexii4 commented Jan 11, 2019

slemeur commented Jan 11, 2019

olexii4 commented Jan 11, 2019

l0rd commented Jan 11, 2019


		}

		export class TestDataProvider implements theia.TreeDataProvider<string> {


		export class TestDataProvider implements theia.TreeDataProvider<string> {

		private onDidChangeTreeDataEmitter: theia.EventEmitter<any> = new theia.EventEmitter<any>();

CHE-11443 Implement the containers plugin #13

CHE-11443 Implement the containers plugin #13

Conversation

olexii4 commented Jan 9, 2019 • edited Loading

AndrienkoAleksandr Jan 9, 2019

Choose a reason for hiding this comment

olexii4 Jan 9, 2019

Choose a reason for hiding this comment

AndrienkoAleksandr Jan 9, 2019

Choose a reason for hiding this comment

olexii4 Jan 10, 2019

Choose a reason for hiding this comment

AndrienkoAleksandr Jan 9, 2019

Choose a reason for hiding this comment

olexii4 Jan 10, 2019

Choose a reason for hiding this comment

olexii4 commented Jan 10, 2019

AndrienkoAleksandr Jan 10, 2019

Choose a reason for hiding this comment

olexii4 Jan 10, 2019 • edited Loading

Choose a reason for hiding this comment

vitaliy-guliy commented Jan 10, 2019

olexii4 commented Jan 10, 2019

olexii4 commented Jan 10, 2019

olexii4 commented Jan 11, 2019

slemeur commented Jan 11, 2019 • edited Loading

olexii4 commented Jan 11, 2019

slemeur commented Jan 11, 2019

olexii4 commented Jan 11, 2019

l0rd commented Jan 11, 2019

olexii4 commented Jan 9, 2019 •

edited

Loading

olexii4 Jan 10, 2019 •

edited

Loading

slemeur commented Jan 11, 2019 •

edited

Loading