Implement remote plugin resources retrieving #430

mmorhun · 2019-09-06T10:13:47Z

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Adds PluginReaderExtension class which handles case when requested resource is not found locally and in such cases sends request to corresponding sidecar where plugin resources are actually stored.

This PR does not handle resources for remote plugin webview because they are handles in a different way than usual plugin resources. Created issue for that problem: eclipse-che/che#14444

Changelog

Added support for remote plugins resources on Che Theia frontend side.

Release Notes

Added support for remote plugins resources on Che Theia frontend side.

Screenshots

Two remote plugins are loaded: Kubernetes plugins and Git UI Tools plugin (last two items in left sidebar)

Fixes eclipse-che/che#13750
Depends on: eclipse-theia/theia#6126

che-bot · 2019-09-06T11:04:36Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-theia" docker image: maxura/che-theia:430
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts

extensions/eclipse-che-theia-plugin-remote/src/node/plugin-reader-extension.ts

AndrienkoAleksandr · 2019-09-06T19:52:38Z

extensions/eclipse-che-theia-plugin-remote/src/node/plugin-remote-init.ts

@@ -214,6 +221,32 @@ to pick-up automatically a free port`));
                    return;
                }

+                // asked to send plugin resource
+                if (jsonParsed.internal.method === 'getResource') {


Sorry, for stop method we have one more check:
jsonParsed.internal.method && jsonParsed.internal.method === 'stop'
Maybe you need to apply jsonParsed.internal.method to your code too?
=> if (jsonParsed.internal.method && jsonParsed.internal.method === 'getResource') {

I don't think so. We are sure that jsonParsed.internal is present. Then we need to check jsonParsed.internal.method field. Of course, we can firstly check for undefined and then compare to method name, but I see no point because we may just check equality. If method field is undefined it is definitely not equal to getResource.

extensions/eclipse-che-theia-plugin-remote/src/node/plugin-reader-extension.ts

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

che-bot · 2019-09-09T07:45:25Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-theia" docker image: maxura/che-theia:430
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

mmorhun · 2019-09-09T09:20:48Z

crw-ci-test

che-bot · 2019-09-09T10:33:42Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-theia" docker image: maxura/che-theia:430
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-09-09T19:57:06Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-theia" docker image: maxura/che-theia:430
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts

vitaliy-guliy · 2019-09-10T09:37:09Z

extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts

+                        'pluginId': pluginId,
+                        'path': resourcePath
+                    }
+                }));


Do we need to call resolve() somewhere in the promise?

We have to call resolve, but not here. It is called here.

extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts

mmorhun · 2019-09-10T13:32:32Z

crw-ci-test

che-bot · 2019-09-10T14:23:35Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
"che-theia" docker image: maxura/che-theia:430

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

…430) * CRW-653 support optional extra processing to check backup registries; tweak console output to report digest and source image when passing, and which image failed if skipping Change-Id: Ieee4cca1344b2dd4f86c10b9e4ceae2eb02dcdd8 Signed-off-by: nickboldt <nboldt@redhat.com> * disable shellcheck SC1091 Change-Id: I1f0a4139ae2aad3359f3fc9c30fa08dc328d893a Signed-off-by: nickboldt <nboldt@redhat.com> * shellcheck disable SC1090 too Change-Id: I798d8146e67bdb1619242f1c1d2c803b05dde3ee Signed-off-by: nickboldt <nboldt@redhat.com> * externalize SCRIPT_DIR and make shellcheck happy too Change-Id: I3e8cfb96e79de1b8dd441075a6f56e8fa9a604fc Signed-off-by: nickboldt <nboldt@redhat.com>

mmorhun requested review from benoitf, tolusha, vitaliy-guliy, AndrienkoAleksandr and akurinnoy September 6, 2019 10:13

mmorhun requested review from evidolob, l0rd, rhopp and vparfonov as code owners September 6, 2019 10:13

mmorhun self-assigned this Sep 6, 2019

mmorhun mentioned this pull request Sep 6, 2019

Add remote plugins resource provider contribution #421

Closed

AndrienkoAleksandr reviewed Sep 6, 2019

View reviewed changes

extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts Outdated Show resolved Hide resolved

AndrienkoAleksandr reviewed Sep 6, 2019

View reviewed changes

extensions/eclipse-che-theia-plugin-remote/src/node/plugin-reader-extension.ts Outdated Show resolved Hide resolved

AndrienkoAleksandr reviewed Sep 6, 2019

View reviewed changes

extensions/eclipse-che-theia-plugin-remote/src/node/plugin-reader-extension.ts Show resolved Hide resolved

Implement remote plugin resources retrieving

7599085

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

mmorhun force-pushed the CHE-13750-2 branch from 1255a5f to 7599085 Compare September 9, 2019 07:14

eclipse-che deleted a comment from che-bot Sep 9, 2019

akurinnoy approved these changes Sep 9, 2019

View reviewed changes

AndrienkoAleksandr approved these changes Sep 10, 2019

View reviewed changes

olexii4 reviewed Sep 10, 2019

View reviewed changes

extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts Show resolved Hide resolved

olexii4 approved these changes Sep 10, 2019

View reviewed changes

vitaliy-guliy reviewed Sep 10, 2019

View reviewed changes

extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts Show resolved Hide resolved

vitaliy-guliy reviewed Sep 10, 2019

View reviewed changes

extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts Show resolved Hide resolved

vitaliy-guliy approved these changes Sep 10, 2019

View reviewed changes

mmorhun merged commit eaaf7db into master Sep 10, 2019

mmorhun deleted the CHE-13750-2 branch September 10, 2019 14:41

dmytro-ndp pushed a commit that referenced this pull request Sep 11, 2019

Implement remote plugin resources retrieving (#430)

2538177

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

azatsarynnyy mentioned this pull request Sep 24, 2019

Icons are missing from VSCode Extensions in che plugins eclipse-che/che#14632

Closed

13 tasks

azatsarynnyy mentioned this pull request Oct 7, 2020

Che Theia Web View doesn't work properly when a plugin is running in its own sidecar eclipse-che/che#16870

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement remote plugin resources retrieving #430

Implement remote plugin resources retrieving #430

mmorhun commented Sep 6, 2019 •

edited

Loading

che-bot commented Sep 6, 2019

AndrienkoAleksandr Sep 6, 2019 •

edited

Loading

mmorhun Sep 9, 2019

che-bot commented Sep 9, 2019

mmorhun commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

vitaliy-guliy Sep 10, 2019

mmorhun Sep 10, 2019

mmorhun commented Sep 10, 2019

che-bot commented Sep 10, 2019

Implement remote plugin resources retrieving #430

Implement remote plugin resources retrieving #430

Conversation

mmorhun commented Sep 6, 2019 • edited Loading

What does this PR do?

Changelog

Release Notes

Screenshots

che-bot commented Sep 6, 2019

AndrienkoAleksandr Sep 6, 2019 • edited Loading

Choose a reason for hiding this comment

mmorhun Sep 9, 2019

Choose a reason for hiding this comment

che-bot commented Sep 9, 2019

mmorhun commented Sep 9, 2019

che-bot commented Sep 9, 2019

che-bot commented Sep 9, 2019

vitaliy-guliy Sep 10, 2019

Choose a reason for hiding this comment

mmorhun Sep 10, 2019

Choose a reason for hiding this comment

mmorhun commented Sep 10, 2019

che-bot commented Sep 10, 2019

mmorhun commented Sep 6, 2019 •

edited

Loading

AndrienkoAleksandr Sep 6, 2019 •

edited

Loading