Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project view is broken if Theia is used as IDE in a workspace #10915

Closed
garagatyi opened this issue Aug 27, 2018 · 4 comments
Closed

Project view is broken if Theia is used as IDE in a workspace #10915

garagatyi opened this issue Aug 27, 2018 · 4 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@garagatyi
Copy link

Description

Project view in a running workspace depends on Ws-agent APIs and opening it when Theia (or no IDE at all) is used shows a black screen.
We can remove this view completely or use just workspace config. We can also provide an error message when a workspace doesn't contain ws-agent.

Reproduction Steps

  1. Create a workspace with Theia and add a project to it
  2. Go to UD view of the project

Expected:
An error about this feature not available for a workspace (we would have the same if no IDE is present in a workspace).
Actual:
Black screen:
image

How it looks on a workspace with the ws-agent:
image

OS and version:

Diagnostics:

@garagatyi garagatyi added kind/bug Outline of a bug - must adhere to the bug report template. team/ide2 labels Aug 27, 2018
@garagatyi
Copy link
Author

@ashumilova

@ashumilova
Copy link
Contributor

ashumilova commented Jan 15, 2019

@slemeur maybe we could remove the project details view?
Here is the information that it contains now:
screenshot from 2019-01-15 13-10-04
It allows only to edit the description and delete the project and those actions depend on wsagent API.
When agent is not running we have following page:
screenshot from 2019-01-15 13-13-35

No agent (in case of Theia IDE or any another except GWT one) - causes the bug described in the following issue. So to fix that we could:
option 1: Remove project details and keep only projects list with nearly the same data
option 2: Show message - there is no ws agent similar to "This project's workspace is not currently running.", but I think - wsagent is more internal stuff, which user may not be aware what that means.

I am +1 for option 1.

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Jan 15, 2019

+1 For first option

@slemeur
Copy link
Contributor

slemeur commented Jan 21, 2019

+1 for option1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

No branches or pull requests

4 participants