Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version prefixes in package.json should be ~ instead of ^ ? #13298

Closed
monaka opened this issue May 9, 2019 · 2 comments
Closed

Version prefixes in package.json should be ~ instead of ^ ? #13298

monaka opened this issue May 9, 2019 · 2 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@monaka
Copy link
Member

monaka commented May 9, 2019

Description

I noticed this on reviewing #13295.

Referring to Contribution Questionnaire, patch releases are not required review.

Per board resolution, service releases of third party libraries do not generally require review.

And referring to the NPM official document, ^ accepts their minor versions. So npm may add unapproved versions if the version range specification with ^.

I think all version ranges in package.json should be prefixed by ~ (refs) instead of ^.

All package.json should be patched?
@monaka monaka added the kind/question Questions that haven't been identified as being feature requests or bugs. label May 9, 2019
@monaka monaka changed the title Vesion prefixes in package.json should be ~ instead of ^ ? Version prefixes in package.json should be ~ instead of ^ ? May 10, 2019
@gorkem
Copy link
Contributor

gorkem commented May 11, 2019

@waynebeaton WDYT? I suppose this is a best practice we should add to project documentation.

@monaka monaka mentioned this issue May 31, 2019
Merged
@che-bot
Copy link
Contributor

che-bot commented Nov 13, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2019
@che-bot che-bot closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gorkem @monaka @che-bot