Terminal is empty on Firefox

[sunix]

TypeError: n.rules is undefined[Learn More] theia.db35f996195e938bb4b2.js:1:1937593
Content Security Policy: The page’s settings blocked the loading of a resource at data:image/svg+xml;base64,PHN2ZyBmaWxsPS… (“img-src”).
Content Security Policy: The page’s settings blocked the loading of a resource at ws://server6pjgqy1m-ws-che-machine-exec-server-4444.192.168.99.100.nip.io/connect (“default-src”).
Error: Failed to create terminal server proxy. Cause: [Exception... "<no message>"  nsresult: "0x805e0006 (<unknown>)"  location: "JS frame :: https://assets.openshift.net/che/theia_artifacts/vendors.49255968b10295ada657.js :: w :: line 1"  data: no]

[AndrienkoAleksandr]

I did some little investigation of this issue. And I see that Firefox blocs not only terminal. It also blocks some svg images(close icons for example, or icons with file type) and maybe some scripts:

Content Security Policy: The page’s settings blocked the loading of a resource at data:image/svg+xml;base64,PHN2ZyBmaWxsPS… (“img-src”).

TypeError: n.rules is undefined[Learn More] theia.fc4330f36128a73453e5.js:1:1878010
    setRules https://assets.openshift.net/che/theia_artifacts/theia.fc4330f36128a73453e5.js:1
    onLoad https://assets.openshift.net/che/theia_artifacts/theia.fc4330f36128a73453e5.js:1
    o https://assets.openshift.net/che/theia_artifacts/theia.fc4330f36128a73453e5.js:1
    setHTML https://assets.openshift.net/che/theia_artifacts/theia.fc4330f36128a73453e5.js:1

This issue is reproducible on the Theia with CDN artifact. Theia which was build without cdn modification works fine.
So, Firefox detects that Theia tried to get some resources or launch scripts by external web links and Firefox block it by Content-Security-Policy(https://content-security-policy.com/)
As I understood, like workaround we could try to patch Theia index.html and apply meta tag with Content-Security-Policy rules and apply cdn links to this role...
@davidfestal I am not security expert, Could you help with this one issue? Maybe you could provide some good solution?

[davidfestal]

@AndrienkoAleksandr I'll look with our CDN / Akamai account contact if he can add the required headers in the files responses returned by the CDN. And will come back to you as soon as I have an answer.

[davidfestal]

OTOH when, in Firefox, I disable CSP (with security.csp.enable to false), I don't have the CSP errors anymore, but I still have the setRules TypeError.

Additionally, even with CSP enabled (=> having the CSP errors on image resources), I'm able to open a working terminal in the theia-ide container.

That makes me think that there might be several problems at the same time here.

@AndrienkoAleksandr Could you also test again in Firefox with security.csp.enable to false, in order to check if there would be any other underlying bug ?

[AndrienkoAleksandr]

@davidfestal I will take a look with security.csp.enable=false and will write result of testing.

[AndrienkoAleksandr]

@davidfestal I tested terminal with security.csp.enable=false. Terminal works nice.

About this one:

Additionally, even with CSP enabled (=> having the CSP errors on image resources), I'm able to open a working terminal in the theia-ide container.

I don't think so. Terminal creation is broken, but if you refresh page - it begin work... So security.csp.enable=true really breaks terminal.

[davidfestal]

@sunix @AndrienkoAleksandr Could you add in this issue the version of Firefox that produces the errors ?

[davidfestal]

My firefox version is 60.6.2esr

[davidfestal]

@amisevsk could you confirm what is the precise version of your more recent Firefox, with which you don't seem to have any such problem ?

[johnmcollier]

I can reproduce on Firefox 67.0.4. Seems to also affect the CSS on the Che-Theia welcome page:

[esubah1989]

I also got this error in Chrome.

[sunix]

still have the issue @davidfestal

[ibuziuk]

moving to 7.2.0 according to the firefox related epic - #14015

[kameshsampath]

I was able open the terminal in FF 69, but i do see some errors in the developer console. I was able to get onto terminal prompt which I was not able to previous versions of FF.

[sunix]

guys,
Looks like i can now open a terminal magically with firefox

[kameshsampath]

yes it has been @sunix with firefox latest.

[AndrienkoAleksandr]

It is working with Che 7.3.0. For Che 7.2.0 and 7.1.0 issue is reproducible for fiirefox 56, 60.4esr, 68.2esr

[AndrienkoAleksandr]

Che 7.3.0 I tested with 56, 60.4esr, 68.2esr(latest esr) and latest firefox 70.0, forks fine, so I close issue. Feel free to reopen if it is reproducible with latest Che.