Support snippets for VS Code extensions running in a Che Theia sidecar

[sunix]

Describe the bug

In Java files, the code snippet (to generate try catch block) try_catch is not working

Che version

• latest

Steps to reproduce

1. Start a Java workspace with a Java project (any of the getting started)
2. Open a Java file
3. type try and Ctrl+space inside a method

Expected behavior

Expected to have the try_catch like in VSCode:

But had no try_catch code snippet :(

Runtime

• Openshift 4.3 and che.openshift.io

[tsmaeder]

FWIW, this works in Theia master with the latest built-ins.

[skabashnyuk]

FWIW, this works in Theia master with the latest built-ins.

@sunix can you test?

[sunix]

FWIW, this works in Theia master with the latest built-ins.

is Theia using the Red Hat Java vscode ext ?

[sunix]

@sunix can you test?

No I don't have Theia installed locally. I let the assignee test with Theia if it is needed.

[IveJ]

Hi David, Plz check che doc for specific details and try to upgrade as appropriately or built your own custom image if necessary.

…

On Wed, Apr 1, 2020, 16:28 Sun Seng David TAN ***@***.***> wrote: @sunix <https://github.com/sunix> can you test? No I don't have Theia installed locally. I let the assignee test with Theia if it is needed. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#16502 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEYAMLZSMQ2JFIZWGY6IV7TRKMCMFANCNFSM4LXWXH3A> .

[sunix]

Sorry guys but it is impossible to code without a minimum of snippet ... main snippet is not working neither ....

[phaumer]

I can confirm this bug as well.

Code snippets that were defined via the VSIX package.json contributes.snippets array appear in Theia, but not Eclipse Che. For example the Red Hat Java VSIX defines two set of snippets.

• One that is just listed in package.json does not work.
• The other set that gets loaded via a VS Code CompletionItemProvider implementation does appear.

Theia 1.0.0/1.2.0:

Che 7.13.1

[tsmaeder]

Confirmed with vscode-java 0.62 in theia and vscode-java 0.63 in openshift.io.

[tsmaeder]

The problem is that the package.json in vscode-java contributes snippets with a relative uri like so:

    "snippets": [
      {
        "language": "java",
        "path": "./snippets/java.json"
      }
    ],

The code in TheiaPluginScanner#readSnippets() constructs an URI from this like so:

uri: FileUri.create(path.join(pck.packagePath, contribution.path)).toString()

This file uri is supposed to refert to a location relative to where package.json of the vscode extension is located. This works fine when the package is installed in the same place as the Theia back end, but fails when the package is located in a sidecar container.

[tsmaeder]

There are two ways we could fix this:

1. Leave the URI as it is, but bring the files to the container where they are expected (where the Theia back end is running)
2. Fix the generation of the URI: we already have a way of resolving sidecar-relative URI's.

My first aproach will be to fix the URI

[ArvinB]

@tsmaeder I like your approach to fix the URI. Will you make this fix and how soon? We can assist by verifying.

[tsmaeder]

I'm working on it.

[tsmaeder]

Turns out the monaco-snippet-suggest-provider.ts uses the FileSystem class directly, not a Resource. Since our workaround is based on resource, it does not get applied. I guess the right thing to do would be to implement file system providers for plugin resources after https://github.com/eclipse-theia/theia/pull/7908/files is merged

[fbricon]

the snippets defined in package.json are only used until the Language Server has started. After that, they're disabled and server-side snippets should take over. See redhat-developer/vscode-java#1101

[tsmaeder]

@fbricon that may be, but the file referenced in package.json still isn't resolved properly. So are you saying the "try" snippet should work eventually? Because I'm not seeing that happening in che-theia.

[ArvinB]

@benoitf We can test and do that. Thank you.

[nickboldt]

doot doot doo... moving stuff to a more reasonable milestone... doot doot doo... paperwork makes the project better...