Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If internal links are not specified, the external one should be used for CHE_API, CHE_KEYCLOAK_AUTH__SERVER__URL, CHE_WORKSPACE_PLUGIN__REGISTRY__URL, CHE_WORKSPACE_DEVFILE__REGISTRY__URL #18643

Closed
4 tasks done
ibuziuk opened this issue Dec 17, 2020 · 0 comments
Assignees
Labels
area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Dec 17, 2020

Is your enhancement related to a problem? Please describe.

The issue is related to #18552 (Che API is not reachable from Che Theia)

The solution was to explicitly refer to external links from internal vars e.g.

This looks like an overkill and if internal links / vars are not specified che server should simply fall back on external ones

TODO:

  • operator must not set internal links if they are externals by fact.
  • update helmcharts correspondingly
  • adopt che-server correspondingly
  • adopt che-theia (if internal is empty then external must be used)

Describe the solution you'd like

if internal links / vars are not specified che server should simply fall back on external ones
There should be no need to explicitly specify internal links

Describe alternatives you've considered

N/A

Additional context

Related to #18552

@ibuziuk ibuziuk added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 17, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 17, 2020
@tolusha tolusha added area/install Issues related to installation, including offline/air gap and initial setup and removed team/deploy labels Dec 17, 2020
@tolusha tolusha added this to the 7.25 milestone Dec 17, 2020
@rhopp rhopp added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 18, 2020
@tolusha tolusha removed this from the 7.25 milestone Dec 18, 2020
@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. labels Dec 18, 2020
@tolusha tolusha added sprint/next team/deploy severity/P1 Has a major impact to usage or development of the system. sprint/current and removed severity/P2 Has a minor but important impact to the usage or development of the system. sprint/next labels Jun 16, 2021
@tolusha tolusha mentioned this issue Jun 18, 2021
3 tasks
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Jun 18, 2021
@tolusha tolusha mentioned this issue Jul 7, 2021
24 tasks
@tolusha tolusha added this to the 7.34 milestone Jul 8, 2021
@tolusha tolusha mentioned this issue Jul 26, 2021
31 tasks
@tolusha tolusha modified the milestones: 7.34, 7.33, 7.35 Jul 28, 2021
@tolusha tolusha closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants