Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[operator] ensure old instances are migrated to use internal services if not specified #19726

Closed
benoitf opened this issue Apr 30, 2021 · 3 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@benoitf
Copy link
Contributor

benoitf commented Apr 30, 2021

Is your task related to a problem? Please describe.

New Eclipse Che instances are using by default internal services

 # Use internal cluster SVC names to communicate between components to speed up the traffic and avoid proxy issues.
useInternalClusterSVCNames: true

but old clusters (having done some upgrades) may not have this parameter set and then the value is defaulted to false while we expect it should be true as well.

Describe the solution you'd like

if the value is not defined, it should set the value to true, not false.

Describe alternatives you've considered

N/A

Additional context

@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Apr 30, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 30, 2021
@tolusha
Copy link
Contributor

tolusha commented Apr 30, 2021

UseInternalClusterSVCNames field doesn't have omitempty attribute.
It means it is defined anyway and it is set to false after update.

[1] https://github.com/eclipse-che/che-operator/blob/main/pkg/apis/org/v1/che_types.go#L141

@JPinkney JPinkney added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 3, 2021
@JPinkney
Copy link
Contributor

JPinkney commented May 3, 2021

Setting as P1 for now. If it's not P1 then please change the priority or if @tolusha's answer solves this then please close!

@tolusha tolusha mentioned this issue Jun 16, 2021
3 tasks
@tolusha
Copy link
Contributor

tolusha commented Jun 16, 2021

We can deprecate this field and enable internal urls by default.
To allow external urls we can introduce a new field like disableInternalClusterSVCNames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants