Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chectl] Add workspace specific "RELATED_IMAGE" to the operator.yaml to make it consistent with csv #20005

Closed
ibuziuk opened this issue Jun 18, 2021 · 4 comments
Closed

[chectl] Add workspace specific "RELATED_IMAGE" to the operator.yaml to make it consistent with csv #20005

ibuziuk opened this issue Jun 18, 2021 · 4 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.33

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jun 18, 2021

Is your enhancement related to a problem? Please describe.

Currently RELATED_IMAGES_* vary across installation methods:

Since it is planned to fall back on the RELATED_IMAGES_* for the kubernetes image puller integration with Eclipse Che it would be great to have the extended list of images available as env vars regardless of the installation method. This issue is important for:

Describe the solution you'd like

RELATED_IMAGES_* are consistent across the installation methods - Operatorhub, chectl (operator), chectl(olm)
Image puller is going to generate the images for pre-pulling based on the RELATED_IMAGES env var

Describe alternatives you've considered

N/A

Additional context

This issue is considered to be an important enhancement for the further kubernetes image puller integration with Eclipse Che:
@ibuziuk ibuziuk added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/chectl Issues related to chectl, the CLI of Che labels Jun 18, 2021
@tolusha
Copy link
Contributor

tolusha commented Jun 18, 2021

We are talking here only about stable version of che-operator.
The next/nightly one won't contain RELATED_IMAGES_* anyway

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 18, 2021

yeah, I believe stable version is fine

@l0rd
Copy link
Contributor

l0rd commented Jul 6, 2021

Should we deprecate installer --operator if OLM is available on the cluster instead? There is a cost maintaining both olm and operator options. What's the value for the user?

@tolusha tolusha mentioned this issue Jul 7, 2021
Closed
24 tasks
@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 7, 2021

I'm fine with deprecating the installer --operator , but this is more a question to the deploy team I believe

@tolusha tolusha removed the area/chectl Issues related to chectl, the CLI of Che label Jul 7, 2021
@tolusha tolusha mentioned this issue Jul 8, 2021
Merged
11 tasks
@tolusha tolusha added this to the 7.33 milestone Jul 8, 2021
@tolusha tolusha closed this as completed Jul 8, 2021
@tolusha tolusha mentioned this issue Jul 26, 2021
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.33
Development

No branches or pull requests
3 participants
@l0rd @ibuziuk @tolusha