Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile projects not working with custom theia editor #20128

Closed
sgraband opened this issue Jul 14, 2021 · 7 comments
Closed

Devfile projects not working with custom theia editor #20128

sgraband opened this issue Jul 14, 2021 · 7 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@sgraband
Copy link

Summary

I have a custom theia editor, that i am deploying to che. Specifying the editor in the devfile works as expected. However, when i specify a project in the devfile, to clone into the workspace, the project is not cloned. I do not get an error, hence it seems like the process for cloning the repository is not even started. There is also no indication in the logs that the cloning is tried.

When trying out a workspace from the default devfile-registry it works. Do i need to configure my theia editor in a specific way to get the support for importing projects via the devfile? Or is this unexpected behavior?

Relevant information

Che Version
7.32.2
Deployed on minikube using chectl

@sgraband sgraband added the kind/question Questions that haven't been identified as being feature requests or bugs. label Jul 14, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 14, 2021
@svor
Copy link
Contributor

svor commented Jul 14, 2021

@sgraband hello,
in che-theia we have workspace-plugin which is responsible for parsing devfile and cloning defined projects.
I'd say there is no easy way to include such functionality into your editor, you have to implement something similar.
@benoitf please correct me if I'm wrong

@sgraband
Copy link
Author

sgraband commented Jul 15, 2021

@svor thanks for your help! Is there any reason why i cannot reuse the existing workspace-plugin?

@l0rd
Copy link
Contributor

l0rd commented Jul 15, 2021

@sgraband the other option you have is to use the devworkspace operator. Note that this is an experimental feature but, in this case, projects are cloned by an init container rather than the editor.

@l0rd l0rd added area/editor/theia Issues related to the che-theia IDE of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 15, 2021
@svor
Copy link
Contributor

svor commented Jul 15, 2021

@svor thanks for your help! Is there any reason why i cannot reuse the existing workspace-plugin?

You can try to reuse it but workspace-plugin depends on another plugins/extensions, so it could be a problem

@sgraband
Copy link
Author

sgraband commented Jul 27, 2021

I tried to enable the devworkspace operator with these instructions. However, i have a few questions:

  • If i understand it correctly the operator enables devfile 2.0 support in Che. Is this correct?
  • Does this also mean i have to use a 2.0 devfile to get the projects to import?
  • Or is this a different feature that should also work with v1 devfiles?
  • For me neither the project cloning nor the devfile 2.0 support seems to work. Are there any additional instructions available than the ones in the link?
  • Last but not least, i wanted to ask whether or not there is a roadmap for this feature set? Is this something that is actively being worked on or are you planning on leaving this up to the editor to implement these functionalities?

@benoitf
Copy link
Contributor

benoitf commented Aug 11, 2021

I tried to enable the devworkspace operator with these instructions. However, i have a few questions:

  • If i understand it correctly the operator enables devfile 2.0 support in Che. Is this correct?

yes correct, it brings devWorkspace support /devfile v2.0 instead of che-server/devfilev1 workspaces

  • Does this also mean i have to use a 2.0 devfile to get the projects to import?

yes, it's handling only devfile 2.1.0+ devfiles

  • Or is this a different feature that should also work with v1 devfiles?

It's a different engine supporting only devfile v2

  • For me neither the project cloning nor the devfile 2.0 support seems to work. Are there any additional instructions available than the ones in the link?

Using the instruction should be enough.

  • Last but not least, i wanted to ask whether or not there is a roadmap for this feature set? Is this something that is actively being worked on or are you planning on leaving this up to the editor to implement these functionalities?

Yes it's actively support as che-server workspaces will be deprecated and replaced by DevWorkspace / DevWorkspace operator

you can track with dedicated milestones in che github tracker
Also most of epics are around devfile v2 support
https://github.com/eclipse/che/issues?q=is%3Aopen+is%3Aissue+label%3Akind%2Fepic+devfile

@che-bot
Copy link
Contributor

che-bot commented Feb 7, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2022
@che-bot che-bot closed this as completed Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants