Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[che-operator] Enhancements in the way how OAuth2 providers can be configured #20496

Closed
skabashnyuk opened this issue Sep 21, 2021 · 6 comments
Closed
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/doc Issues related to documentation kind/enhancement A feature request - must adhere to the feature request template. kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Sep 21, 2021

Is your task related to a problem? Please describe

  • Github, Gitlab, Bitbucket should be configured in a similar way.
  • Factory OAuth flow without Keycloak.

Describe the solution you'd like

Release Notes Text

The way to configure GitHub, Bitbucket and Gitlab as Git service providers for Che workspaces has been made consistent and simpler.

@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Sep 21, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 21, 2021
@azatsarynnyy azatsarynnyy added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 21, 2021
@l0rd
Copy link
Contributor

l0rd commented Sep 22, 2021

👍

@skabashnyuk skabashnyuk added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Sep 22, 2021
@tolusha tolusha mentioned this issue Sep 28, 2021
27 tasks
@tolusha tolusha added this to the 7.38 milestone Sep 28, 2021
@MichalMaler MichalMaler added area/doc Issues related to documentation kind/enhancement A feature request - must adhere to the feature request template. labels Sep 29, 2021
@tolusha
Copy link
Contributor

tolusha commented Oct 6, 2021

GitHub configuration secret:

kind: Secret
apiVersion: v1
metadata:
  name: github-oauth-config
  namespace: <...> 
  labels:
    app.kubernetes.io/part-of: che.eclipse.org
    app.kubernetes.io/component: oauth-scm-configuration
  annotations:
    che.eclipse.org/oauth-scm-server: github
type: Opaque
data:
  id: <...> 
  secret: <...> 

Mount env to che-server deployment:

  • CHE_OAUTH2_GITHUB_CLIENTID__FILEPATH with content of id key to location /che-conf/oauth/github/id
  • CHE_OAUTH2_GITHUB_CLIENTSECRET__FILEPATH with content of secret key to location /che-conf/oauth/github/secret

@tolusha
Copy link
Contributor

tolusha commented Oct 6, 2021

GitLab configuration secret:

kind: Secret
apiVersion: v1
metadata:
  name: gitlab-oauth-config
  namespace: <...> 
  labels:
    app.kubernetes.io/part-of: che.eclipse.org
    app.kubernetes.io/component: oauth-scm-configuration
  annotations:
    che.eclipse.org/oauth-scm-server: gitlab
    che.eclipse.org/scm-server-endpoint: <...>  # optional
type: Opaque
data:
  id: <...> 
  secret: <...> 

Mount env to che-server deployment:

  • CHE_OAUTH_GITLAB_CLIENTID__FILEPATH with content of id key to location /che-conf/oauth/gitlab/id
  • CHE_OAUTH_GITLAB_CLIENTSECRET__FILEPATH with content of secret key to location /che-conf/oauth/gitlab/secret

Configmap:

  • CHE_INTEGRATION_GITLAB_SERVER__ENDPOINTS with content of che.eclipse.org/scm-server-endpoint to che configmap

@tolusha tolusha closed this as completed Oct 7, 2021
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Oct 12, 2021
@devstudio-release
Copy link

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-2373

@max-cx
Copy link

max-cx commented Nov 16, 2021

@tolusha, do we need to add any new content to the Installation Guide or Administration Guide or End-user Guide?

Yes/No?

@max-cx
Copy link

max-cx commented Nov 16, 2021

@tolusha, I updated the Release Notes Text for this issue:


= Standardized configuration of OAuth 2.0 for GitLab, GitHub, and Bitbucket

This enhancement standardizes and simplifies the use of Secret config files for OAuth 2.0 configuration of git-hosting services (Gitlab, Github, and Bitbucket) for Che workspaces.


Feel free to okay, comment, or correct it in https://issues.redhat.com/browse/CRW-2373.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/doc Issues related to documentation kind/enhancement A feature request - must adhere to the feature request template. kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

8 participants