Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

403 error, not able to do git push to upstream dashboard branch with https #21627

Closed
Tracked by #21615
dkwon17 opened this issue Aug 9, 2022 · 4 comments
Closed
Tracked by #21615
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Aug 9, 2022

Describe the bug

On a Che instance with oAuth set up, I'm not able to push branches to https://github.com/eclipse-che/che-dashboard/.

Che version

next (development version)

Steps to reproduce

  1. Create a project with this devfile https://github.com/dkwon17/che-dashboard/blob/devfilev2/devfile.yaml
    ex:
{CHEHOST}/#https://raw.githubusercontent.com/dkwon17/che-dashboard/devfilev2/devfile.yaml
  1. When the editor starts, run git checkout -b test-branch
  2. Create a git commit
  3. Try to push to the upstream remote with git push upstream test-branch

This results in the following:

bash-4.4$ git push upstream test-branch
remote: Permission to eclipse-che/che-dashboard.git denied to dkwon17.
fatal: unable to access 'https://github.com/eclipse-che/che-dashboard.git/': The requested URL returned error: 403

Expected behavior

Should be able to push to remote

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

other (please specify in additional context)

Eclipse Che Logs

No response

Additional context

I experience this issue in the dogfooding instance

@dkwon17 dkwon17 added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/git labels Aug 9, 2022
@dkwon17 dkwon17 mentioned this issue Aug 9, 2022
67 tasks
@dkwon17 dkwon17 changed the title Not able to do git push to upstream branch 403 error, not able to do git push to upstream branch Aug 9, 2022
@dkwon17 dkwon17 changed the title 403 error, not able to do git push to upstream branch 403 error, not able to do git push to upstream branch with https Aug 9, 2022
@dkwon17 dkwon17 changed the title 403 error, not able to do git push to upstream branch with https 403 error, not able to do git push to upstream dashboard branch with https Aug 9, 2022
@vinokurig
Copy link
Contributor

This is an expected behaiviour because OAuth App access restrictions are enabled by default in a GitHub organisation.
To request the access:

  1. Review authorized OAuth Apps in your GitHub account page.
  2. Find the related oAuth app in the list and click it:
    screenshot-github com-2022 08 16-15_41_19
  3. Request access for the eclipse-che organization:
    screenshot-github com-2022 08 16-15_43_30

@l0rd
Copy link
Contributor

l0rd commented Aug 16, 2022

Honestly that doesn't seams like a big deal as usually developers fork a GitHub repository and git push to their fork rather than to a dedicated branch of the upstream repository.

@dkwon17 dkwon17 added severity/P2 Has a minor but important impact to the usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. labels Aug 17, 2022
@svor
Copy link
Contributor

svor commented Aug 27, 2022

It seems there is nothing to fix, can we close the issue and suggest to create a fork and do push commands into that fork?
@vinokurig @dkwon17 WDYT?

@dkwon17
Copy link
Contributor Author

dkwon17 commented Aug 29, 2022

I think we can close this issue, although, the procedure described here #21627 (comment) would have to be done to make PRs to che-dashboard since at least for now, the PR checks are done only for PRs made from branches on the upstream repo (eclipse-che/che-dashboard)

@svor svor closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants