Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces are using old UDI images #21979

Closed
Tracked by #22027 ...
amisevsk opened this issue Feb 1, 2023 · 4 comments
Closed
Tracked by #22027 ...

Workspaces are using old UDI images #21979

amisevsk opened this issue Feb 1, 2023 · 4 comments
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/devfile-registry area/plugin-registry area/samples kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@amisevsk
Copy link
Contributor

amisevsk commented Feb 1, 2023

Describe the bug

Workspaces end up using very old UDI images. This may be due to switching to using container-contributions, as it means that the original devfile's container is used.

Examples:

  • Go sample: Uses quay.io/devfile/universal-developer-image:ubi8-0e189d9, which is over a year old (devfile.yaml)
  • Empty workspace: Uses quay.io/devfile/universal-developer-image:ubi8-38da5c2, which is 6 months old

Further, the plugin registry contains editor definitions that use out-of-date UDI images as well (che-editors.yaml):

  • quay.io/devfile/universal-developer-image:ubi8-13008af - 3 months old
  • quay.io/devfile/universal-developer-image:ubi8-9436df2 - 9 months old

These images are used for the 'main' container for workspaces which do not specify an image

Finally, installing Che next via chectl creates a checluster with

  devEnvironments:
    defaultComponents:
    - container:
        image: quay.io/devfile/universal-developer-image:ubi8-38da5c2
        sourceMapping: /projects
      name: universal-developer-image

Che version

next (development version)

Steps to reproduce

Start workspaces via the dashboard samples

Expected behavior

Workspaces should either use UDI images matching the currently installed version of Che (tagged accordingly) or use the latest UDI images. We should either

  • Add automation to keep UDI tags up to date across all repositories (including sample repositories)
  • Use latest tags for images in sample repositories
  • Add functionality to dashboard to automatically select correct UDI image for currently installed version of Che

Areas that need updating

  • UDI images should be built + tagged matching Che releases. Currently, only ubi8-<commit-hash> images are available, which makes updating difficult + manual
  • Sample repositories (e.g. https://github.com/che-samples/golang-example/blob/devfilev2/devfile.yaml) should use ubi8-latest images in their devfiles to avoid needing to constantly update them, or we should add automation to keep these images up to date.
  • Chectl needs to automatically get the correct UDI image tag for the current release and use it as the default component
  • Plugin registry should get the correct UDI image and use that everywhere

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/next

Environment

other (please specify in additional context)

Eclipse Che Logs

No response

Additional context

No response

@amisevsk amisevsk added kind/bug Outline of a bug - must adhere to the bug report template. area/devfile-registry area/plugin-registry labels Feb 1, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 1, 2023
@amisevsk amisevsk added the area/chectl Issues related to chectl, the CLI of Che label Feb 1, 2023
@tolusha tolusha added area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator and removed area/chectl Issues related to chectl, the CLI of Che labels Feb 2, 2023
@nickboldt
Copy link
Contributor

@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 2, 2023
@amisevsk
Copy link
Contributor Author

amisevsk commented Feb 2, 2023

That automation would help, but there are some additional issues:

  • CheCluster gets old UDI version in default component (would need to update che-operator it seems)
  • All repos used for samples need their devfiles to be maintained to grab newer UDI images (or just go with latest?)

@l0rd l0rd mentioned this issue Mar 6, 2023
45 tasks
@nickboldt
Copy link
Contributor

So yeah, you're saying "bring downstream back upstream" :D

If samples were moved INTO the same devfile registry repo, that would make things simpler... and I'm working on a way to achieve "build my devfile registry from LOCAL devfiles in a folder" rather than "build my devfile registry by parsing meta.yaml to find the other GH repo in which the sample project lives" because that's a use case we essentially have to support in Brew.

@svor
Copy link
Contributor

svor commented Mar 29, 2023

che-samples, che-plugin registry and che-operator were updated to use UDI:latest

@svor svor closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/devfile-registry area/plugin-registry area/samples kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants