-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GIT+SSH URLs when starting workspaces #22025
Comments
Re-opening this issue because I am afraid that there is still a missing part: the devfile in the git repository is ignored. This issue was about:
|
@l0rd Could you add more pieces of information on why you think so? |
@olexii4 Sorry I haven't tested or review the PR. I was assuming that the work that has been completed dashboard-side only and that the devfile cannot be resolved from a GIT+SSH URL. I am probably wrong though. Can you please help me understanding how the resolution is done? |
I found that the It always resolves the default defile: @tolusha WDYT? |
Closing as this is mostly done. I have opened a separate issue for the missing part: |
Is your enhancement related to a problem? Please describe
Today it's not possible to start a workspace from an git repository URL using the GIT+SSH protocol:
git@github.com:eclipse/che.git
.Even if the user has configured an SSH secret to be automatically mounted in workspaces and had uploaded the public key in its git service, starting a workspace won't work.
Describe the solution you'd like
If a user has configured SSH (secret created in his namespace + key uploaded to git service) or a git credential secret, then Che should be able to start a workspace from a GIT+SSH repository URL: if there is a devfile at the root of the git repo it should be used to define the corresponding DevWorkspace.
I think there are 3 possible solutions here:
devworkspace-generator
npm library (similar to @amisevsk work)Other considerations
Through the GIT+SSH protocol Che would be able to fully support any git service. That won't replace the HTTP + OAuth flow that remains the preferred if support (GitHub, BB, GitLab and Azure DevOps), but an alternative that allows Che to work on other services too (gerrit, gogs, githut...).
Screenshots
Dashboard doesn't even allow to provide a git repo URL that doesn't use HTTP: ⬇️
That what happen if I try the URL
https://<che-host>/f?url=git%40github.com%3Al0rd%2Fgo-hello-world.git
⬇️The text was updated successfully, but these errors were encountered: