Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade npm packages in dashboard. #13207

Closed
wants to merge 4 commits into from
Closed

[WIP] Upgrade npm packages in dashboard. #13207

wants to merge 4 commits into from

Conversation

monaka
Copy link
Member

@monaka monaka commented Apr 23, 2019

What does this PR do?

Upgrades versions of node packages used in Dashboard.
The patches should be passed Eclipse CQ. (please see each commit log also)

What issues does this PR fix or reference?

none.

@che-bot
Copy link
Contributor

che-bot commented Apr 23, 2019

Can one of the admins verify this patch?

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented Apr 23, 2019

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Apr 23, 2019

Can one of the admins verify this patch?

@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@monaka monaka added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Apr 23, 2019
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing CQs for updating direct dependencies
and missing CQ for new dev dependencies (like eslint)

This is Eclipse CQ approval since they are patch-level updates.

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
Eclipse CQ #10397.

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
Eclipse CQ #14919.

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@l0rd
Copy link
Contributor

l0rd commented Jul 31, 2019

Beyond the CQs issue we cannot merge this before the GA release

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 31, 2019
@dmytro-ndp
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 8, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13207
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@eclipse-che eclipse-che deleted a comment from che-bot Aug 8, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Aug 8, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 8, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:13207

@l0rd
Copy link
Contributor

l0rd commented Aug 22, 2019

Removing do-not-merge/hold. @monaka can you rebase please? What's the status of the CQs?

@monaka monaka changed the title Upgrade npm packages in dashboard. [WIP] Upgrade npm packages in dashboard. Aug 29, 2019
@monaka
Copy link
Member Author

monaka commented Aug 29, 2019

I rebased this. And some issues may be fixed by #14313. So I set WIP to this PR for now. This will be back after #14313 was merged.

@monaka
Copy link
Member Author

monaka commented Jan 14, 2020

I close it as it's too old.

@monaka monaka closed this Jan 14, 2020
@monaka monaka deleted the pr-upgrade-npm-packages-in-dashboard branch January 14, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants