Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS-SELENIUM] Create class for interaction with workspace API #13295

Closed
wants to merge 10 commits into from
Closed

[TS-SELENIUM] Create class for interaction with workspace API #13295

wants to merge 10 commits into from

Conversation

Ohrimenko1988
Copy link
Contributor

What does this PR do?

Create a class for interaction with workspace API

What issues does this PR fix or reference?

issue: #13291

Release Notes

Docs PR

@Ohrimenko1988
Install 'axios' instead 'typed-rest-client'
7ce3c9a 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Create 'TestWorkspace' class for working with workspace API
d62c52c 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Create 'TestWorkspace' class for working with workspace API
10da9a2 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988 Ohrimenko1988 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels May 7, 2019
@Ohrimenko1988
Do changes according to review
08557d4 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Copy link
Contributor Author

ci-build

monaka
monaka requested changes May 7, 2019
View reviewed changes
e2e/package.json Outdated Show resolved Hide resolved
@Ohrimenko1988
Update 'axios' version according to CQ
aa35982 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Update 'Chai' version according to CQ
80c27ef 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Update 'inversify' version according to CQ
8c57e87 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Update 'reflect-metadata' version according to CQ
1cb0e7e 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Update 'typescript' version according to CQ
7ce5847 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Update 'ts-node' version according to CQ
9e3995e 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988 Ohrimenko1988 requested a review from monaka May 8, 2019 21:16
monaka
monaka reviewed May 9, 2019
View reviewed changes
Copy link
Member

@monaka monaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after CQ requests are fixed.

e2e/package.json Show resolved Hide resolved
e2e/package.json Show resolved Hide resolved
@monaka monaka mentioned this pull request May 9, 2019
Closed
@monaka monaka self-requested a review May 30, 2019 04:02
@monaka
Copy link
Member

monaka commented May 30, 2019

LGTM as CQ passed.

@Ohrimenko1988 Could you resolve some conflicts and re-push ?

@Ohrimenko1988 Ohrimenko1988 deleted the selen-add-workspace-api branch February 13, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@monaka monaka monaka approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ohrimenko1988 @monaka @musienko-maxim