Add sparseCheckoutDir parameter into devfile spec #14823

mmorhun · 2019-10-09T10:00:50Z

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Adds non mandatory attribute sparseCheckoutDir into devfile specification. The attribute is added under source section of a project.
Adds new sparse_checkout_dir column into devfile_project table of Che database.

What issues does this PR fix or reference?

Implements Che server side of the issue

Release Notes

Added sparseCheckoutDir parameter for git type of projects

Docs PR

eclipse-che/che-docs#842
redhat-developer/devfile#53

che-bot · 2019-10-09T10:09:15Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14823
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2019-10-09T10:16:16Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
test report
logs and configs
"che-server" docker image: maxura/che-server:14823
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-09T10:37:47Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
logs and configs
"che-server" docker image: maxura/che-server:14823

che-bot · 2019-10-09T11:16:11Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14823

...ace/src/main/java/org/eclipse/che/api/workspace/server/devfile/convert/ProjectConverter.java

sleshchenko

In general LGTM. Take a look inline comments

...thub/src/main/java/org/eclipse/che/api/factory/server/github/GithubSourceStorageBuilder.java

wsmaster/che-core-api-workspace/src/main/resources/schema/devfile.json

skabashnyuk

Documentation changes needed for this pr.

che-bot · 2019-10-10T13:34:25Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
logs and configs
"che-server" docker image: maxura/che-server:14823

che-bot · 2019-10-10T14:22:50Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14823
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

apupier · 2019-10-10T15:53:01Z

direct link to the single failing test:
https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2617//Selenium_20tests_20report/

apupier · 2019-10-11T08:45:54Z

the single failing test is DirectUrlFactoryWithSpecificBranchTest.factoryWithDirectUrlWithSpecificBranch which seems to be failing on master too #14842

mmorhun · 2019-10-11T12:41:46Z

@skabashnyuk here is docs PRs (updated description):
eclipse-che/che-docs#842
redhat-developer/devfile#53

But I believe we should not merge them before frontend part of this issue is merged.

mmorhun · 2019-10-11T12:45:50Z

@musienko-maxim could you please test factories scenario against this PR? Also please test factory keepDir feature.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

mmorhun · 2019-10-16T06:07:40Z

Rebased

che-bot · 2019-10-16T06:19:20Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
logs and configs
"che-server" docker image: maxura/che-server:14823

che-bot · 2019-10-16T07:02:08Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14823

...rkspace/src/test/resources/devfile/schema_test/devfile/devfile_with_sparse_checkout_dir.yaml

sleshchenko

LGTM

Make sure that you merged before release. Otherwise move migration scripts to 7.4.0 folder

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

che-bot · 2019-10-16T12:00:44Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
logs and configs
"che-server" docker image: maxura/che-server:14823

che-bot · 2019-10-16T12:43:18Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14823
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

mmorhun · 2019-10-16T13:01:26Z

ci-test

che-bot · 2019-10-16T13:03:17Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14823
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

mmorhun · 2019-10-16T14:24:44Z

Test failed because of network issue:

Failed to transfer file: https://oss.sonatype.org/content/repositories/snapshots/org/eclipse/che/depmgt/maven-depmgt-pom/7.3.0-SNAPSHOT/maven-metadata.xml. Return code is: 504 , ReasonPhrase:Gateway Time-out.

mmorhun · 2019-10-16T14:24:54Z

ci-test

che-bot · 2019-10-16T15:19:56Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:14823
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

musienko-maxim · 2019-10-17T08:44:29Z

The DirectUrlFactoryWithSpecificBranchTest was rechecked locally, and passed.

mmorhun requested review from metlos, skabashnyuk, mshaposhnik, mkuznyetsov and sleshchenko October 9, 2019 10:00

mmorhun requested review from l0rd, nickboldt and rhopp as code owners October 9, 2019 10:00

mmorhun self-assigned this Oct 9, 2019

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Oct 9, 2019

mmorhun force-pushed the CHE-13671 branch from 88eed7c to 84d3904 Compare October 9, 2019 10:12

mshaposhnik reviewed Oct 9, 2019

View reviewed changes

...ace/src/main/java/org/eclipse/che/api/workspace/server/devfile/convert/ProjectConverter.java Show resolved Hide resolved

mshaposhnik approved these changes Oct 9, 2019

View reviewed changes

sleshchenko reviewed Oct 9, 2019

View reviewed changes

skabashnyuk reviewed Oct 9, 2019

View reviewed changes

mmorhun added 2 commits October 16, 2019 09:00

Add sparseCheckoutDir parameter into devfile spec

bfb37e2

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Changes accordinig to PR feedback

c0128db

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

mmorhun force-pushed the CHE-13671 branch from bb9e8b7 to c0128db Compare October 16, 2019 06:06

mmorhun requested a review from skabashnyuk October 16, 2019 06:12

AndrienkoAleksandr reviewed Oct 16, 2019

View reviewed changes

...rkspace/src/test/resources/devfile/schema_test/devfile/devfile_with_sparse_checkout_dir.yaml Show resolved Hide resolved

AndrienkoAleksandr approved these changes Oct 16, 2019

View reviewed changes

sleshchenko approved these changes Oct 16, 2019

View reviewed changes

skabashnyuk approved these changes Oct 16, 2019

View reviewed changes

Move migration script to 7.4 version

fc47388

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

musienko-maxim self-requested a review October 17, 2019 08:44

musienko-maxim approved these changes Oct 17, 2019

View reviewed changes

mmorhun merged commit 420d4ea into master Oct 17, 2019

mmorhun deleted the CHE-13671 branch October 17, 2019 09:01

Mbd06b mentioned this pull request Jan 6, 2020

Duplicate directory specifying multiple projects in a devfile. #15607

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sparseCheckoutDir parameter into devfile spec #14823

Add sparseCheckoutDir parameter into devfile spec #14823

mmorhun commented Oct 9, 2019 •

edited

Loading

che-bot commented Oct 9, 2019

che-bot commented Oct 9, 2019

che-bot commented Oct 9, 2019

che-bot commented Oct 9, 2019

sleshchenko left a comment

skabashnyuk left a comment

che-bot commented Oct 10, 2019

che-bot commented Oct 10, 2019

apupier commented Oct 10, 2019

apupier commented Oct 11, 2019

mmorhun commented Oct 11, 2019 •

edited

Loading

mmorhun commented Oct 11, 2019

mmorhun commented Oct 16, 2019

che-bot commented Oct 16, 2019

che-bot commented Oct 16, 2019

sleshchenko left a comment

che-bot commented Oct 16, 2019

che-bot commented Oct 16, 2019

mmorhun commented Oct 16, 2019

che-bot commented Oct 16, 2019

mmorhun commented Oct 16, 2019

mmorhun commented Oct 16, 2019

che-bot commented Oct 16, 2019

musienko-maxim commented Oct 17, 2019

Add sparseCheckoutDir parameter into devfile spec #14823

Add sparseCheckoutDir parameter into devfile spec #14823

Conversation

mmorhun commented Oct 9, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

che-bot commented Oct 9, 2019

che-bot commented Oct 9, 2019

che-bot commented Oct 9, 2019

che-bot commented Oct 9, 2019

sleshchenko left a comment

Choose a reason for hiding this comment

skabashnyuk left a comment

Choose a reason for hiding this comment

che-bot commented Oct 10, 2019

che-bot commented Oct 10, 2019

apupier commented Oct 10, 2019

apupier commented Oct 11, 2019

mmorhun commented Oct 11, 2019 • edited Loading

mmorhun commented Oct 11, 2019

mmorhun commented Oct 16, 2019

che-bot commented Oct 16, 2019

che-bot commented Oct 16, 2019

sleshchenko left a comment

Choose a reason for hiding this comment

che-bot commented Oct 16, 2019

che-bot commented Oct 16, 2019

mmorhun commented Oct 16, 2019

che-bot commented Oct 16, 2019

mmorhun commented Oct 16, 2019

mmorhun commented Oct 16, 2019

che-bot commented Oct 16, 2019

musienko-maxim commented Oct 17, 2019

mmorhun commented Oct 9, 2019 •

edited

Loading

mmorhun commented Oct 11, 2019 •

edited

Loading