Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set basic access authentication for registries requests #15292

Merged
merged 3 commits into from
Nov 26, 2019
Merged

Set basic access authentication for registries requests #15292

merged 3 commits into from
Nov 26, 2019

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 25, 2019

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

This PR sets basic access authentication for plugin and devfile registries.

What issues does this PR fix or reference?

#14627

@olexii4
set basic access authentication for requests to the plugin and devfil…
e714dd5 
…e registries

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Nov 25, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 25, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 25, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@akurinnoy
Copy link
Contributor

@olexii4 I wonder why you didn't use keycloak-token-interceptor.ts to fix resolve this issue?

@olexii4
Copy link
Contributor Author

olexii4 commented Nov 25, 2019

@akurinnoy In issue #14627 we decide to provide an ability to configure plugin/devfile registries as secure. That is why I added dummy implementation as a first step.

Ok. I will change it

@skabashnyuk
Copy link
Contributor

@olexii4 @akurinnoy until we introduce secure registry feature can you just remove any authorization header at all?

CC @l0rd

@akurinnoy
Copy link
Contributor

@skabashnyuk Sure, that was my advise to @olexii4

@olexii4
Copy link
Contributor Author

olexii4 commented Nov 25, 2019

@skabashnyuk done

@che-bot
Copy link
Contributor

che-bot commented Nov 25, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 25, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 25, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@olexii4 olexii4 merged commit 2cc7da5 into master Nov 26, 2019
@olexii4 olexii4 deleted the CHE-14627 branch November 26, 2019 09:56
@olexii4 olexii4 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 26, 2019
@che-bot che-bot added this to the 7.5.0 milestone Nov 26, 2019
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
@olexii4
Set basic access authentication for registries requests (#15292)
6e5fd6c 
* set basic access authentication for requests to the plugin and devfile registries

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurinnoy akurinnoy akurinnoy approved these changes

@benoitf benoitf benoitf approved these changes

@ashumilova ashumilova Awaiting requested review from ashumilova

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@evidolob evidolob Awaiting requested review from evidolob

@mmorhun mmorhun Awaiting requested review from mmorhun

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@olexii4 @che-bot @akurinnoy @skabashnyuk @benoitf