Remove unused values from che.properties and related code #18202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
requested review from
ibuziuk,
nickboldt and
sleshchenko
as code owners
skabashnyuk
requested review from
mshaposhnik,
sparkoo and
metlos
and removed request for
nickboldt and
ibuziuk
13 tasks
che-bot
added
status/code-review
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
mshaposhnik
approved these changes
Oct 26, 2020
metlos
approved these changes
Oct 27, 2020
sparkoo
approved these changes
Oct 27, 2020
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove unused values from che.properties and related code
Screenshot/screencast of this PR
n/a
What issues does this PR fix or reference?
Fixes #14946
Reference #18159
How to test this PR?
quay.io/skabashn/che-server:che14946PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.