Move Dev Spaces typescript functional tests, clean up outdated code #22100

nallikaea · 2023-03-27T09:43:27Z

What does this PR do?

Move Factory tests and Quarkus sample test from downstream to this project;
Created logout() method to make possible to run a few test specs in one test run;
README updated;
Outdated code deleted;
Some typos fixed;

Screenshot/screencast of this PR

Full log:
test_output_log.txt

None: some tests skipped because of specific cluster set ups.

What issues does this PR fix or reference?

CRW-4091

How to test this PR?

export USERSTORY=Quarkus && npm run test-userstory

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

dmytro-ndp · 2023-03-27T10:30:12Z

tests/e2e/constants/TestConstants.ts

+    ----------------------------------------------*/
+    TS_SELENIUM_TYPESCRIPT_DEBUG_IMAGE: process.env.TS_SELENIUM_TYPESCRIPT_DEBUG_IMAGE || 'quay.io/eclipse/che-nodejs10-ubi:7.35.2',
+
+    TS_SELENIUM_PHP_DEBUG_IMAGE: process.env.TS_SELENIUM_PHP_DEBUG_IMAGE || 'registry.redhat.io/codeready-workspaces/stacks-php-rhel8:latest',


It could be probably outdated.

Would you revise constants and remove those which havn't been used in tests after clean up of Che Theia tests?

If there no any reference in tests, should I delete it? Nothing uses for example on ci somehow?

Yes, there are no other downstream tests but e2e-codeready project.

Upstream CIs are:

che-operator PR check (Add the Smoke test PR check for Operator repository #22046)

chectl PR check (Add the Smoke test PR check for chectl repository #22101)

dmytro-ndp · 2023-03-27T10:37:58Z

tests/e2e/configs/inversify.config.ts

 e2eContainer.bind<Sanitizer>(CLASSES.Sanitizer).to(Sanitizer);
 e2eContainer.bind<ApiUrlResolver>(CLASSES.ApiUrlResolver).to(ApiUrlResolver);
 e2eContainer.bind<WorkspaceHandlingTests>(CLASSES.WorkspaceHandlingTests).to(WorkspaceHandlingTests);

+if (TestConstants.TS_OCP_LOGIN_PAGE_PROVIDER_TITLE === 'DevSandbox') {


Would it be simpler to get rid of ICheLoginPage and use RedHatLoginPage only?

It can be, but can you help me with the list of instances I should test that loggin is correct?
cc: @ScrewTSW

As far as I know, these tests are run against OCP only, including:

Eclipse Che deployed to dogfooding instance https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/

Eclipse Che deployed to OpenShift.CI

Dev Spaces on test OCP instances

Dev Spaces on DevSandbox staging

Dev Spaces on DevSandbox production

@ScrewTSW could you help me to run tests on DevSandbox and dogfooding locally, please?

@nallikaea : I could also help you with runing the test using https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/DevSandbox/job/sandbox-test/

thank you, done

Test build failed:

docker run --shm-size=${shmSize} \\ -v ${WORKSPACE}/report/${USERNAME}:/tmp/report:Z \\ -v ${WORKSPACE}/video/${USERNAME}:/tmp/ffmpeg_report:Z \\ -e TS_SELENIUM_BASE_URL="${accountDsDashboardUrl}" \\ -e TS_SELENIUM_LOG_LEVEL="DEBUG" \\ -e TS_SELENIUM_USERNAME=${USERNAME} \\ -e TS_SELENIUM_PASSWORD=${PASSWORD} \\ -e E2E_OPENSHIFT_TOKEN="${accountToken}" \\ -e DELETE_WORKSPACE_ON_FAILED_TEST=true \\ -e TS_SELENIUM_START_WORKSPACE_TIMEOUT=${START_WORKSPACE_TIMEOUT} \\ -e NODE_TLS_REJECT_UNAUTHORIZED=0 \\ -e TS_SELENIUM_EDITOR=che-code \\ -e USERSTORY=EmptyWorkspace \\ -e TS_OCP_LOGIN_PAGE_PROVIDER_TITLE="DevSandbox" \\ -e TS_SELENIUM_REPORT_FOLDER="/tmp/report" \\ -e VIDEO_RECORDING=true \\ quay.io/crw_pr/che-e2e:22100 ... Running TEST_SUITE: test-happy-path with user: osio-ci-devsandbox-periodic-stg 10:00:34 + ffmpeg_pid=127 10:00:34 + trap kill_ffmpeg 2 15 10:00:34 + echo 'Running TEST_SUITE: test-happy-path with user: osio-ci-devsandbox-periodic-stg' 10:00:34 + npm run test-happy-path 10:00:34 + nohup ffmpeg -y -video_size 1920x1080 -framerate 24 -f x11grab -i :20.0 /tmp/ffmpeg_report/output.mp4 10:00:35 npm ERR! Missing script: "test-happy-path" ...

https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/DevSandbox/job/sandbox-test/5711/console

For the record: EmptyWorkspace test passed being run against Dev Spaces on regular OCP cluster https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/7293/

docker run --shm-size=4096m -p 5920:5920 \ -e TS_SELENIUM_LOAD_PAGE_TIMEOUT=420000 \ -e TS_SELENIUM_BASE_URL=https://devspaces.apps.ocp412.crw-qe.com/ \ -e DELETE_WORKSPACE_ON_FAILED_TEST=true \ -e TS_SELENIUM_START_WORKSPACE_TIMEOUT=600000 \ -e NODE_TLS_REJECT_UNAUTHORIZED=0 \ -e VIDEO_RECORDING=true \ -e E2E_OCP_CLUSTER_API_URL=https://api.ocp412.crw-qe.com:6443/ \ -e TS_SELENIUM_LOG_LEVEL=TRACE \ -e TS_EDITOR_TAB_INTERACTION_TIMEOUT=20_000 \ -e TS_WAIT_LOADER_PRESENCE_TIMEOUT=600000 \ -e OCP_INFRA=PSI \ -v /tmp:/usr/local/bin:Z \ -v /home/hudson/.kube:/home/seluser/.kube:Z \ -v /mnt/hudson_workspace/workspace/Testing/e2e/basic/typescript-tests/test-repo/tests/e2ereport:/tmp/e2e/report:Z \ -v /mnt/hudson_workspace/workspace/Testing/e2e/basic/typescript-tests/test-repo/tests/e2evideo:/tmp/ffmpeg_report:Z \ -e USERSTORY=EmptyWorkspace \ -e TS_SELENIUM_VALUE_OPENSHIFT_OAUTH=true \ -e TS_OCP_LOGIN_PAGE_PROVIDER_TITLE=htpasswd \ -e TS_SELENIUM_OCP_USERNAME=***** \ -e 'TS_SELENIUM_OCP_PASSWORD=******' \ -e TS_SELENIUM_EDITOR=che-code quay.io/crw_pr/che-e2e:22100

✅ Successful run on DevSandbox: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/DevSandbox/job/sandbox-test/5716/console

And there is successful run against downstream Dev Spaces: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/7294/

dmytro-ndp · 2023-03-27T10:45:59Z

@nallikaea : what do you think about further code simplification, and getting rid of inversify library, together with interfaces:

replace IOcpLoginPage with RedHatLoginPage
replace IDriver with ChromeDriver
replace ITestWorkspaceUtil with TestWorkspaceUtil
replace ICheLoginPage with RedHatLoginPage
delete IAuthorizationHeaderHandler and CheMultiuserAuthorizationHeaderHandler
?

nallikaea · 2023-03-27T11:08:39Z

@nallikaea : what do you think about further code simplification, and getting rid of inversify library, together with interfaces:

replace IOcpLoginPage with RedHatLoginPage

replace IDriver with ChromeDriver

replace ITestWorkspaceUtil with TestWorkspaceUtil

replace ICheLoginPage with RedHatLoginPage

delete IAuthorizationHeaderHandler and CheMultiuserAuthorizationHeaderHandler
?

We can do it
Maybe it is better to create another PR?

artaleks9

It seems, this can be deleted from the 'TestConstans':
TS_SELENIUM_SINGLE_HOST
TS_SELENIUM_USERNAME
TS_SELENIUM_PASSWORD
TS_SELENIUM_EMAIL_USER
TS_SELENIUM_FIRST_NAME
TS_SELENIUM_LAST_NAME

Is this used anywhere?
@dmytro-ndp @ScrewTSW

dmytro-ndp · 2023-03-27T14:11:04Z

@nallikaea : what do you think about further code simplification, and getting rid of inversify library, together with interfaces:

replace IOcpLoginPage with RedHatLoginPage

replace IDriver with ChromeDriver

replace ITestWorkspaceUtil with TestWorkspaceUtil

replace ICheLoginPage with RedHatLoginPage

delete IAuthorizationHeaderHandler and CheMultiuserAuthorizationHeaderHandler
?

We can do it Maybe it is better to create another PR?

IMHO, it should make migration simpler, shouldn't it?
Why not do it right now, all at once?

dmytro-ndp · 2023-03-27T14:12:20Z

It seems, this can be deleted from the 'TestConstans': TS_SELENIUM_SINGLE_HOST TS_SELENIUM_USERNAME TS_SELENIUM_PASSWORD TS_SELENIUM_EMAIL_USER TS_SELENIUM_FIRST_NAME TS_SELENIUM_LAST_NAME

Is this used anywhere? @dmytro-ndp @ScrewTSW

Agree.
It looks like leftovers from the time we had been testing Che Keycloak.

ScrewTSW · 2023-03-27T14:43:35Z

@dmytro-ndp @nallikaea AFAIK TS_SELENIUM_USERNAME and TS_SELENIUM_PASSWORD are still utilized in various login providers. I'd be careful about those two.

nallikaea · 2023-03-27T15:21:43Z

TS_SELENIUM_PASSWORD and TS_SELENIUM_USERNAME used in the classes RedHatLoginPage and OcpRedHatLoginPage.

@injectable()
export class RedHatLoginPage {

    constructor(
        @inject(CLASSES.DriverHelper) private readonly driverHelper: DriverHelper) { }

    async waitRedHatLoginWelcomePage() {
        Logger.debug('RedHatLoginPage.waitRedHatLoginWelcomePage');
        await this.driverHelper.waitVisibility(By.id(USERNAME_INPUT_ID));
    }

    async enterPasswordRedHat() {
        Logger.debug('RedHatLoginPage.enterPasswordRedHat');
        const passwordFieldLocator: By = By.id(PASSWORD_INPUT_ID);
        await this.driverHelper.waitVisibility(passwordFieldLocator, 3000);
        await this.driverHelper.enterValue(passwordFieldLocator, **TestConstants.TS_SELENIUM_PASSWORD,** timeout );

if (TestConstants.TS_OCP_LOGIN_PAGE_PROVIDER_TITLE === 'DevSandbox') {
    e2eContainer.bind<RedHatLoginPage>(CLASSES.RedHatLoginPage).to(RedHatLoginPage);
    e2eContainer.rebind<ICheLoginPage>(TYPES.CheLogin).to(OcpRedHatLoginPage);
}

@ScrewTSW @dmytro-ndp @artaleks9 so should we keep it or it outdated pageoblects?

dmytro-ndp · 2023-03-27T15:39:30Z

@nallikaea , @ScrewTSW, @artaleks9 : okay, I have also found https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/DevSandbox/sandbox-test.jenkinsfile#L175-177

Let's keep next constants then:

TS_SELENIUM_PASSWORD
TS_SELENIUM_USERNAME

nallikaea · 2023-03-27T15:40:25Z

I updated PR

  9 passing (2m)

            ‣ DriverHelper.wait (5000 milliseconds)
            ‣ DriverHelper.getDriver

Process finished with exit code 0

tests/e2e/package.json

Signed-off-by: mdolhalo <mdolhalo@redhat.com>

Signed-off-by: mdolhalo <mdolhalo@redhat.com> Signed-off-by: mdolhalo <mdolhalo@redhat.com>

dmytro-ndp

Looks good to merge.

Thanks for handling feedback, @nallikaea !

ScrewTSW

LGTM

tests/e2e/configs/mocharc.ts

nallikaea requested review from musienko-maxim, nickboldt, ScrewTSW and dmytro-ndp as code owners March 27, 2023 09:43

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Mar 27, 2023

nallikaea force-pushed the crw-4091 branch from ba34736 to 5a5cd86 Compare March 27, 2023 09:54

dmytro-ndp reviewed Mar 27, 2023

View reviewed changes

musienko-maxim approved these changes Mar 27, 2023

View reviewed changes

artaleks9 reviewed Mar 27, 2023

View reviewed changes

nallikaea force-pushed the crw-4091 branch from 5a5cd86 to bffd45f Compare March 27, 2023 15:40

nallikaea force-pushed the crw-4091 branch from bffd45f to 8ff5ee8 Compare March 27, 2023 16:31

dmytro-ndp reviewed Mar 27, 2023

View reviewed changes

tests/e2e/package.json Outdated Show resolved Hide resolved

nallikaea force-pushed the crw-4091 branch 4 times, most recently from 86cecc2 to ccf317e Compare March 28, 2023 14:35

Move Dev Spaces typescript functional tests, clean up outdated code

e20d5f1

Signed-off-by: mdolhalo <mdolhalo@redhat.com>

nallikaea force-pushed the crw-4091 branch from ccf317e to e20d5f1 Compare March 29, 2023 06:57

mdolhalo added 2 commits March 29, 2023 10:24

updated entrypoint.sh

79ed9b2

Signed-off-by: mdolhalo <mdolhalo@redhat.com>

updated inversify.config.ts

3d8744d

Signed-off-by: mdolhalo <mdolhalo@redhat.com>

nallikaea force-pushed the crw-4091 branch from 03d1011 to 3d8744d Compare March 29, 2023 10:30

fix logout methods for DevSandbox

4fda559

Signed-off-by: mdolhalo <mdolhalo@redhat.com> Signed-off-by: mdolhalo <mdolhalo@redhat.com>

dmytro-ndp approved these changes Mar 29, 2023

View reviewed changes

ScrewTSW approved these changes Mar 29, 2023

View reviewed changes

dmytro-ndp reviewed Mar 29, 2023

View reviewed changes

tests/e2e/configs/mocharc.ts Show resolved Hide resolved

dmytro-ndp merged commit db63138 into eclipse-che:main Mar 29, 2023

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 29, 2023

nallikaea deleted the crw-4091 branch April 13, 2023 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Dev Spaces typescript functional tests, clean up outdated code #22100

Move Dev Spaces typescript functional tests, clean up outdated code #22100

nallikaea commented Mar 27, 2023 •

edited

Loading

dmytro-ndp Mar 27, 2023 •

edited

Loading

nallikaea Mar 27, 2023 •

edited by dmytro-ndp

Loading

dmytro-ndp Mar 27, 2023 •

edited

Loading

dmytro-ndp Mar 27, 2023

nallikaea Mar 27, 2023

dmytro-ndp Mar 27, 2023

nallikaea Mar 27, 2023

dmytro-ndp Mar 28, 2023

nallikaea Mar 29, 2023

dmytro-ndp Mar 29, 2023 •

edited

Loading

dmytro-ndp Mar 29, 2023 •

edited

Loading

nallikaea Mar 29, 2023

dmytro-ndp Mar 29, 2023

dmytro-ndp commented Mar 27, 2023

nallikaea commented Mar 27, 2023

artaleks9 left a comment •

edited

Loading

dmytro-ndp commented Mar 27, 2023 •

edited

Loading

dmytro-ndp commented Mar 27, 2023 •

edited

Loading

ScrewTSW commented Mar 27, 2023

nallikaea commented Mar 27, 2023 •

edited

Loading

dmytro-ndp commented Mar 27, 2023 •

edited

Loading

nallikaea commented Mar 27, 2023 •

edited

Loading

dmytro-ndp left a comment

ScrewTSW left a comment

Move Dev Spaces typescript functional tests, clean up outdated code #22100

Move Dev Spaces typescript functional tests, clean up outdated code #22100

Conversation

nallikaea commented Mar 27, 2023 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

dmytro-ndp Mar 27, 2023 • edited Loading

Choose a reason for hiding this comment

nallikaea Mar 27, 2023 • edited by dmytro-ndp Loading

Choose a reason for hiding this comment

dmytro-ndp Mar 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp Mar 29, 2023 • edited Loading

Choose a reason for hiding this comment

dmytro-ndp Mar 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmytro-ndp commented Mar 27, 2023

nallikaea commented Mar 27, 2023

artaleks9 left a comment • edited Loading

Choose a reason for hiding this comment

dmytro-ndp commented Mar 27, 2023 • edited Loading

dmytro-ndp commented Mar 27, 2023 • edited Loading

ScrewTSW commented Mar 27, 2023

nallikaea commented Mar 27, 2023 • edited Loading

dmytro-ndp commented Mar 27, 2023 • edited Loading

nallikaea commented Mar 27, 2023 • edited Loading

dmytro-ndp left a comment

Choose a reason for hiding this comment

ScrewTSW left a comment

Choose a reason for hiding this comment

nallikaea commented Mar 27, 2023 •

edited

Loading

dmytro-ndp Mar 27, 2023 •

edited

Loading

nallikaea Mar 27, 2023 •

edited by dmytro-ndp

Loading

dmytro-ndp Mar 27, 2023 •

edited

Loading

dmytro-ndp Mar 29, 2023 •

edited

Loading

dmytro-ndp Mar 29, 2023 •

edited

Loading

artaleks9 left a comment •

edited

Loading

dmytro-ndp commented Mar 27, 2023 •

edited

Loading

dmytro-ndp commented Mar 27, 2023 •

edited

Loading

nallikaea commented Mar 27, 2023 •

edited

Loading

dmytro-ndp commented Mar 27, 2023 •

edited

Loading

nallikaea commented Mar 27, 2023 •

edited

Loading