From aa692e6b6d79143eef4e8aa8e9062e30a0f1a19c Mon Sep 17 00:00:00 2001
From: hizir-bc <hizir-cagin.bektas@broadcom.com>
Date: Thu, 21 Dec 2023 10:25:31 +0100
Subject: [PATCH] 2 more type check added

---
 .../services/LanguageClientServiceTest.spec.ts         |  4 ++--
 clients/cobol-lsp-vscode-extension/src/extension.ts    |  2 +-
 .../src/services/Settings.ts                           |  2 +-
 .../src/services/copybook/CopybookDownloadService.ts   | 10 +++++-----
 clients/cobol-lsp-vscode-extension/tsconfig.json       |  2 ++
 5 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/clients/cobol-lsp-vscode-extension/src/__tests__/services/LanguageClientServiceTest.spec.ts b/clients/cobol-lsp-vscode-extension/src/__tests__/services/LanguageClientServiceTest.spec.ts
index e55ddb69a9..2acb413d6a 100644
--- a/clients/cobol-lsp-vscode-extension/src/__tests__/services/LanguageClientServiceTest.spec.ts
+++ b/clients/cobol-lsp-vscode-extension/src/__tests__/services/LanguageClientServiceTest.spec.ts
@@ -100,7 +100,7 @@ describe("LanguageClientService positive scenario", () => {
       .mockReturnValue(9999);
     try {
       await languageClientService.checkPrerequisites();
-    } catch (error) {
+    } catch (error: any) {
       message = error;
     }
     expect(message).toBeFalsy();
@@ -236,7 +236,7 @@ describe("LanguageClientService negative scenario.", () => {
     (fs.existsSync as any) = jest.fn().mockReturnValue(false);
     try {
       await new LanguageClientService(jest.fn() as any).checkPrerequisites();
-    } catch (error) {
+    } catch (error: any) {
       expect(error.toString()).toBe("Error: LSP server for cobol not found");
     }
   });
diff --git a/clients/cobol-lsp-vscode-extension/src/extension.ts b/clients/cobol-lsp-vscode-extension/src/extension.ts
index 8899682df2..7eff6f074f 100644
--- a/clients/cobol-lsp-vscode-extension/src/extension.ts
+++ b/clients/cobol-lsp-vscode-extension/src/extension.ts
@@ -98,7 +98,7 @@ export async function activate(
     } else {
       await languageClientService.checkPrerequisites();
     }
-  } catch (err) {
+  } catch (err: any) {
     outputChannel.appendLine(err.toString());
     languageClientService.enableNativeBuild();
     TelemetryService.registerExceptionEvent(
diff --git a/clients/cobol-lsp-vscode-extension/src/services/Settings.ts b/clients/cobol-lsp-vscode-extension/src/services/Settings.ts
index f93dd7b295..dcbc5a4f0c 100644
--- a/clients/cobol-lsp-vscode-extension/src/services/Settings.ts
+++ b/clients/cobol-lsp-vscode-extension/src/services/Settings.ts
@@ -83,7 +83,7 @@ export function createFileWithGivenPath(
       fs.mkdirSync(ch4zPath, { recursive: true });
       fs.writeFileSync(filePath, pattern);
     }
-  } catch (e) {
+  } catch (e: any) {
     vscode.window.showErrorMessage("File error: " + e.toString());
   }
 }
diff --git a/clients/cobol-lsp-vscode-extension/src/services/copybook/CopybookDownloadService.ts b/clients/cobol-lsp-vscode-extension/src/services/copybook/CopybookDownloadService.ts
index d823eb26c9..d881f47207 100644
--- a/clients/cobol-lsp-vscode-extension/src/services/copybook/CopybookDownloadService.ts
+++ b/clients/cobol-lsp-vscode-extension/src/services/copybook/CopybookDownloadService.ts
@@ -105,7 +105,7 @@ export class CopybookDownloadService implements vscode.Disposable {
         copybookProfile.profile,
         isUSS,
       );
-    } catch (error) {
+    } catch (error: any) {
       if (CopybookDownloadService.isInvalidCredentials(error)) {
         throw error;
       }
@@ -194,7 +194,7 @@ export class CopybookDownloadService implements vscode.Disposable {
           copybookprofile.profile,
           isUSS,
         );
-      } catch (err) {
+      } catch (err: any) {
         if (CopybookDownloadService.needsUserNotification([copybookprofile])) {
           vscode.window.showErrorMessage(err.message);
         }
@@ -290,7 +290,7 @@ export class CopybookDownloadService implements vscode.Disposable {
         }
       }
       await Promise.all(promises);
-    } catch (e) {
+    } catch (e: any) {
       if (CopybookDownloadService.isInvalidCredentials(e)) {
         throw e;
       }
@@ -316,7 +316,7 @@ export class CopybookDownloadService implements vscode.Disposable {
       if (fetchResult) {
         this.updateDownloadProgress(progress, errors, cp);
       }
-    } catch (e) {
+    } catch (e: any) {
       if (CopybookDownloadService.isInvalidCredentials(e)) {
         throw e;
       }
@@ -571,7 +571,7 @@ export class CopybookDownloadService implements vscode.Disposable {
           true,
         );
       }
-    } catch (e) {
+    } catch (e: any) {
       let errorMessage = e.toString();
       if (CopybookDownloadService.isInvalidCredentials(e)) {
         errorMessage = INVALID_CREDENTIALS_ERROR_MSG.replace(
diff --git a/clients/cobol-lsp-vscode-extension/tsconfig.json b/clients/cobol-lsp-vscode-extension/tsconfig.json
index 4e0da6e629..46ec6d9a23 100644
--- a/clients/cobol-lsp-vscode-extension/tsconfig.json
+++ b/clients/cobol-lsp-vscode-extension/tsconfig.json
@@ -23,6 +23,8 @@
     "strictBindCallApply": true,
     "strictFunctionTypes": true,
     "strictPropertyInitialization": true,
+    "alwaysStrict": true,
+    "strict": true,
     "lib": ["es6"],
     "module": "commonjs",
     "moduleResolution": "node",