Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of type and id #88

Closed
wolf4ood opened this issue Nov 7, 2024 · 0 comments · Fixed by #114
Closed

Usage of type and id #88

wolf4ood opened this issue Nov 7, 2024 · 0 comments · Fixed by #114
Labels
enhancement New feature or request triage all new issues awaiting classification

Comments

@wolf4ood
Copy link
Contributor

wolf4ood commented Nov 7, 2024 •
edited
Loading

What's missing?

Usage of type and id in all examples and in dcp @context

Why should it be in the spec?

Credential context, like other contests alias @type and @id to type and id.

this means that when credential context is included in dcp messages e.g. (https://www.w3.org/2018/credentials/v1)
it will cause the compaction to use type and id.

In order to keep the consistency of message payloads i would suggest to include this alias in thedspace-dcp context and use type and id instead of @type and @id in all examples.

Where should this be added?

No response

More context

No response
@wolf4ood wolf4ood added enhancement New feature or request triage all new issues awaiting classification labels Nov 7, 2024
@arnoweiss arnoweiss mentioned this issue Nov 12, 2024
Merged
@wolf4ood wolf4ood mentioned this issue Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage all new issues awaiting classification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: replace @type with type and roundTrip testing wolf4ood/tx-identity-trust
1 participant
@wolf4ood