Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer UI - autocomplete for search #1580

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

thfries
Copy link
Contributor

@thfries thfries commented Feb 20, 2023

please find this PR that enables a typeahead search for things search.
Let me know, what you think about it.
There is also some work prepared to filter the connection logs but this is not ready yet and commented out.

Best regards, Thomas

Signed-off-by: thfries <thomas.fries0@gmail.com>
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thfries
I just had a look at the added autocomplete functionality for search and I think it's great 👍
Also very cool to have the "recent" searches available as suggestion ..

The functionality with the "fieldList" and the "filterList" is kind of hidden .. I wonder if we need to provide documentation for such very hidden features..
What do you think?

rql: `exists(${FILTER_PLACEHOLDER})`,
group: 'Other',
},
...(Environments.current().filterList ?? []).map((f) => ({label: f, rql: f, group: 'Favourite'})),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we mainly use American English in docs and UI .. so please change to "Favorite"

Signed-off-by: thfries <thomas.fries0@gmail.com>
@thfries
Copy link
Contributor Author

thfries commented Feb 23, 2023

Hi @thjaeckle,
thanks for the feedback.
I changed the spelling to AE like proposed and added a new commit.

The former menu of the dropdown button is inconsistent to the auto complete dropdown. I was thinking about making them consistent or to remove the dropdown button. The dropdown button is still nice, because otherwise you don't know what you can search for by typing. But the autocomplete could contain much more entries.

Agree! Documentation would be good. We can create additional documentation pages but some integrated online hints would be preferable I think. I can take a look how this could be done.

@thjaeckle thjaeckle added this to the 3.2.0 milestone Feb 23, 2023
@thjaeckle thjaeckle added the UI Issues related to the Ditto explorer UI label Feb 23, 2023
@thjaeckle thjaeckle merged commit 389d003 into eclipse-ditto:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Issues related to the Ditto explorer UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants